Changeset 84150 in webkit

Timestamp:

Apr 18, 2011 9:23:57 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

2011-04-18 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Backspace in the Console is broken
​https://bugs.webkit.org/show_bug.cgi?id=58764

• inspector/front-end/inspector.js: (WebInspector.documentKeyDown):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-18  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Backspace in the Console is broken
+        https://bugs.webkit.org/show_bug.cgi?id=58764
+
+        * inspector/front-end/inspector.js:
+        (WebInspector.documentKeyDown):
+
 2011-04-18  Hans Wennborg  <hans@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -792 +792 @@
             if (!isMac)
                 PageAgent.reloadPage(event.ctrlKey || event.shiftKey);
+            break;
+        case "U+0008": // Backspace
+            if (this.currentFocusElement && document.defaultView) {
+                // We inhibit the Backspace default handling for non-editable elements
+                // (which otherwise may result into a navigation to the previous history entry with a docked inspector).
+                var computedStyle = document.defaultView.getComputedStyle(this.currentFocusElement, null, "");
+                var userModify = computedStyle.getPropertyValue("-webkit-user-modify");
+                if (!userModify || userModify === "read-only")
+                    event.preventDefault();
+            }
             break;
     }