Changeset 84152 in webkit

Timestamp:

Apr 18, 2011 9:48:58 AM (13 years ago)

Author:

morrita@google.com

Message:

2011-04-18 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
​https://bugs.webkit.org/show_bug.cgi?id=58791

On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
We should guard it again RefPtr.

• html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLDetailsElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-18  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039
+        https://bugs.webkit.org/show_bug.cgi?id=58791
+        
+        On refreshMainSummary(), findMainSummary() possibly releases oldSummary.
+        We should guard it again RefPtr.
+
+        * html/HTMLDetailsElement.cpp:
+        (WebCore::HTMLDetailsElement::refreshMainSummary):
+
 2011-04-18  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/html/HTMLDetailsElement.cpp

@@ -77 +77 @@
 void HTMLDetailsElement::refreshMainSummary(RefreshRenderer refreshRenderer)
 {
-    Node* oldSummary = m_mainSummary;
+    RefPtr<Node> oldSummary = m_mainSummary;
     m_mainSummary = findMainSummary();