Changeset 84153 in webkit

Timestamp:

Apr 18, 2011 9:55:14 AM (13 years ago)

Author:

andersca@apple.com

Message:

2011-04-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Reproducible crash in Find on Page, on pages that use accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=58793
<rdar://problem/9295870>

Move the call to PageOverlay::setNeedsDisplay() back to WebPage::installPageOverlay;
it needs to be called after we've told the drawing area that a page overlay has been installed.

• WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setPage):
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/PageOverlay.cpp (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-18  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Reproducible crash in Find on Page, on pages that use accelerated compositing
+        https://bugs.webkit.org/show_bug.cgi?id=58793
+        <rdar://problem/9295870>
+
+        Move the call to PageOverlay::setNeedsDisplay() back to WebPage::installPageOverlay;
+        it needs to be called after we've told the drawing area that a page overlay has been installed.
+
+        * WebProcess/WebPage/PageOverlay.cpp:
+        (WebKit::PageOverlay::setPage):
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::installPageOverlay):
+
 2011-04-18  Jeff Miller  <jeffm@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp

@@ -83 +83 @@
     m_webPage = webPage;
     m_client->didMoveToWebPage(this, webPage);
-
-    if (m_webPage)
-        setNeedsDisplay();
 
     m_fadeAnimationTimer.stop();

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -744 +744 @@
 
     m_drawingArea->didInstallPageOverlay();
+    m_pageOverlay->setNeedsDisplay();
 }