Changeset 84207 in webkit
- Timestamp:
- Apr 18, 2011 4:31:42 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r84206 r84207 1 2011-04-18 Dirk Pranke <dpranke@chromium.org> 2 3 Reviewed by Eric Seidel. 4 5 new-run-webkit-tests: add an --additional-drt-flag option 6 https://bugs.webkit.org/show_bug.cgi?id=58680 7 8 NRWT has a bunch of command line flags that exist to pass 9 custom flags to DRT, especially on chromium. It would be nice 10 if there was a generic mechanism to pass through flags so we 11 didn't have all the custom ones. 12 13 * Scripts/webkitpy/layout_tests/port/chromium.py: 14 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 15 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 16 * Scripts/webkitpy/layout_tests/port/test.py: 17 * Scripts/webkitpy/layout_tests/port/webkit.py: 18 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 19 1 20 2011-04-05 Jer Noble <jer.noble@apple.com> 2 21 -
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
r84205 r84207 376 376 if self._port.get_option('enable_hardware_gpu'): 377 377 cmd.append('--enable-hardware-gpu') 378 379 cmd.extend(self._port.get_option('additional_drt_flag', [])) 378 380 return cmd 379 381 -
trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
r83475 r84207 40 40 from webkitpy.layout_tests.port import test 41 41 42 from webkitpy.tool import mocktool 43 mock_options = mocktool.MockOptions(use_apache=True, 44 configuration='Release') 45 42 46 43 47 class MockDRTPortTest(port_testcase.PortTestCase): 44 def make_port(self ):48 def make_port(self, options=mock_options): 45 49 if sys.platform == 'win32': 46 50 # We use this because the 'win' port doesn't work yet. 47 return mock_drt.MockDRTPort(port_name='mock-chromium-win' )48 return mock_drt.MockDRTPort( )51 return mock_drt.MockDRTPort(port_name='mock-chromium-win', options=options) 52 return mock_drt.MockDRTPort(options=options) 49 53 50 54 def test_default_worker_model(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
r83646 r84207 77 77 return 78 78 self.assertTrue(len(port.driver_cmd_line())) 79 80 options = mocktool.MockOptions(additional_drt_flag=['--foo=bar', '--foo=baz']) 81 port = self.make_port(options=options) 82 cmd_line = port.driver_cmd_line() 83 self.assertTrue('--foo=bar' in cmd_line) 84 self.assertTrue('--foo=baz' in cmd_line) 79 85 80 86 def disabled_test_http_server(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
r83646 r84207 423 423 424 424 def cmd_line(self): 425 return [self._port._path_to_driver()] 425 return [self._port._path_to_driver()] + self._port.get_option('additional_drt_flag', []) 426 426 427 427 def poll(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
r83646 r84207 373 373 def cmd_line(self): 374 374 cmd = self._command_wrapper(self._port.get_option('wrapper')) 375 cmd += [self._port._path_to_driver(), '-'] 376 375 cmd.append(self._port._path_to_driver()) 377 376 if self._port.get_option('pixel_tests'): 378 377 cmd.append('--pixel-tests') 379 378 cmd.extend(self._port.get_option('additional_drt_flag', [])) 379 cmd.append('-') 380 380 return cmd 381 381 -
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
r83783 r84207 293 293 default=False, help="Reset any existing baselines to the " 294 294 "generated results"), 295 optparse.make_option("--additional-drt-flag", action="append", 296 default=[], help="Additional command line flag to pass to DumpRenderTree " 297 "Specify multiple times to add multiple flags."), 295 298 optparse.make_option("--additional-platform-directory", action="append", 296 299 default=[], help="Additional directory where to look for test "
Note: See TracChangeset
for help on using the changeset viewer.