Changeset 84211 in webkit

Timestamp:

Apr 18, 2011 5:00:46 PM (13 years ago)

Author:

eric@webkit.org

Message:

2011-04-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should show trailing-days pass counts for queues
​https://bugs.webkit.org/show_bug.cgi?id=58812

This lets us see if each bot is pulling its own weight or not.
Before I wrote this patch our suspicious was that one of the
cq bots was doing most of the work. Turns out they're actually
pretty even in their recent pass counts.

• QueueStatusServer/handlers/queuestatus.py:
• QueueStatusServer/index.yaml:
• QueueStatusServer/templates/queuestatus.html:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/handlers/queuestatus.py (modified) (4 diffs)
• QueueStatusServer/index.yaml (modified) (1 diff)
• QueueStatusServer/templates/queuestatus.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-18  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        queues.webkit.org should show trailing-days pass counts for queues
+        https://bugs.webkit.org/show_bug.cgi?id=58812
+
+        This lets us see if each bot is pulling its own weight or not.
+        Before I wrote this patch our suspicious was that one of the
+        cq bots was doing most of the work.  Turns out they're actually
+        pretty even in their recent pass counts.
+
+        * QueueStatusServer/handlers/queuestatus.py:
+        * QueueStatusServer/index.yaml:
+        * QueueStatusServer/templates/queuestatus.html:
+
 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/QueueStatusServer/handlers/queuestatus.py

@@ -27 +27 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import datetime
 import itertools
 
@@ -59 +60 @@
     def _fetch_statuses(self, queue, bot_id):
         statuses = queuestatus.QueueStatus.all()
-        statuses = statuses.filter("queue_name =", queue.name())
+        statuses.filter("queue_name =", queue.name())
         if bot_id:
             statuses.filter("bot_id =", bot_id)
@@ -66 +67 @@
     def _fetch_last_message_matching(self, queue, bot_id, message):
         statuses = queuestatus.QueueStatus.all()
-        statuses = statuses.filter("queue_name =", queue.name())
+        statuses.filter("queue_name =", queue.name())
         if bot_id:
             statuses.filter("bot_id =", bot_id)
         statuses.filter("message =", message)
         return statuses.order("-date").get()
+
+    def _fetch_trailing_days_pass_count(self, queue, bot_id, days):
+        statuses = queuestatus.QueueStatus.all()
+        statuses.filter("queue_name =", queue.name())
+        days_ago = datetime.datetime.now() - datetime.timedelta(days=days)
+        statuses.filter("date >", days_ago)
+        if bot_id:
+            statuses.filter("bot_id =", bot_id)
+        statuses.filter("message =", "Pass")
+        return statuses.count()
 
     def _page_title(self, queue, bot_id):
@@ -93 +104 @@
             "last_pass": self._fetch_last_message_matching(queue, bot_id, "Pass"),
             "last_boot": self._fetch_last_message_matching(queue, bot_id, "Starting Queue"),
+            "trailing_month_pass_count": self._fetch_trailing_days_pass_count(queue, bot_id, 30),
+            "trailing_week_pass_count": self._fetch_trailing_days_pass_count(queue, bot_id, 7),
         }
         self.response.out.write(template.render("templates/queuestatus.html", template_values))

trunk/Tools/QueueStatusServer/index.yaml

@@ -44 +44 @@
   - name: queue_name
   - name: date
+
+- kind: QueueStatus
+  properties:
+  - name: message
+  - name: queue_name
+  - name: date
     direction: desc
 

trunk/Tools/QueueStatusServer/templates/queuestatus.html

@@ -21 +21 @@
 {% endif %}
 </div>
+<div>7-day "Pass" count: {{ trailing_week_pass_count }}</div>
+<div>30-day "Pass" count: {{ trailing_month_pass_count }}</div>
 
 <h3>Recent Status</h3>