Changeset 84214 in webkit


Ignore:
Timestamp:
Apr 18, 2011 6:40:21 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-18 Jon Lee <jonlee@apple.com>

Reviewed by Maciej Stachowiak.

Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
https://bugs.webkit.org/show_bug.cgi?id=58824
<rdar://problem/9292680>

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r84213 r84214  
     12011-04-18  Jon Lee  <jonlee@apple.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
     6        https://bugs.webkit.org/show_bug.cgi?id=58824
     7        <rdar://problem/9292680>
     8
     9        * rendering/RenderListBox.cpp:
     10        (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars
     11
    1122011-04-18  John Bauman  <jbauman@chromium.org>
    213
  • trunk/Source/WebCore/rendering/RenderListBox.cpp

    r83832 r84214  
    274274    RenderBlock::paintObject(paintInfo, tx, ty);
    275275
    276     if (paintInfo.phase == PaintPhaseBlockBackground)
    277         paintScrollbar(paintInfo, tx, ty);
    278     else if (paintInfo.phase == PaintPhaseChildBlockBackground || paintInfo.phase == PaintPhaseChildBlockBackgrounds) {
     276    switch (paintInfo.phase) {
     277    // Depending on whether we have overlay scrollbars they
     278    // get rendered in the foreground or background phases
     279    case PaintPhaseForeground:
     280        if (m_vBar->isOverlayScrollbar())
     281            paintScrollbar(paintInfo, tx, ty);
     282        break;
     283    case PaintPhaseBlockBackground:
     284        if (!m_vBar->isOverlayScrollbar())
     285            paintScrollbar(paintInfo, tx, ty);
     286        break;
     287    case PaintPhaseChildBlockBackground:
     288    case PaintPhaseChildBlockBackgrounds: {
    279289        int index = m_indexOffset;
    280290        while (index < listItemsSize && index <= m_indexOffset + numVisibleItems()) {
     
    282292            index++;
    283293        }
     294        break;
     295    }
     296    default:
     297        break;
    284298    }
    285299}
Note: See TracChangeset for help on using the changeset viewer.