Changeset 84313 in webkit


Ignore:
Timestamp:
Apr 19, 2011 4:43:03 PM (13 years ago)
Author:
ojan@chromium.org
Message:

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

don't show missing text results for tests that only dump image results
​https://bugs.webkit.org/show_bug.cgi?id=58931

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r84312 r84313  
     12011-04-19  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        don't show missing text results for tests that only dump image results
     6        https://bugs.webkit.org/show_bug.cgi?id=58931
     7
     8        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
     9        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
     10
     112011-04-19  Ojan Vafai  <ojan@chromium.org>
     12
     13        Reviewed by Eric Seidel.
     14
     15        don't show failures table if there are only new tests
     16        https://bugs.webkit.org/show_bug.cgi?id=58929
     17
     18        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
     19
    1202011-04-19  Ojan Vafai  <ojan@chromium.org>
    221

  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html

    r84312 r84313  
    326326            html += resultLink(stripExtension(test), fileSuffix, linkName);
    327327        else {
    328             if (g_results.tests[test].is_missing_audio)
     328            var testObject = g_results.tests[test];
     329            if (testObject.is_missing_audio)
    329330                html += resultLink(stripExtension(test), '-actual.wav', 'audio result');
    330             else {
     331            if (testObject.is_missing_text)
    331332                html += resultLink(stripExtension(test), fileSuffix, linkName);
    332                 if (g_results.tests[test].is_missing_image)
    333                     html += resultLink(stripExtension(test), '-actual.png', 'png result');
    334             }
     333            if (testObject.is_missing_image)
     334                html += resultLink(stripExtension(test), '-actual.png', 'png result');
    335335        }
    336336       

  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py

    r84294 r84313  
    162162            tests[test]['is_mismatch_reftest'] = True
    163163
     164        if test_failures.FailureMissingResult in failure_types:
     165            tests[test]['is_missing_text'] = True
     166
    164167        if test_failures.FailureMissingImage in failure_types or test_failures.FailureMissingImageHash in failure_types:
    165168            tests[test]['is_missing_image'] = True
Note: See TracChangeset for help on using the changeset viewer.