Changeset 84400 in webkit


Ignore:
Timestamp:
Apr 20, 2011 11:54:13 AM (13 years ago)
Author:
evan@chromium.org
Message:

2011-04-20 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] expose title text direction on WebDataSource
https://bugs.webkit.org/show_bug.cgi?id=59010

  • public/WebDataSource.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::pageTitle): (WebKit::WebDataSourceImpl::pageTitleDirection):
  • src/WebDataSourceImpl.h:
Location:
trunk/Source/WebKit/chromium
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r84358 r84400  
     12011-04-20  Evan Martin  <evan@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        [chromium] expose title text direction on WebDataSource
     6        https://bugs.webkit.org/show_bug.cgi?id=59010
     7
     8        * public/WebDataSource.h:
     9        * src/WebDataSourceImpl.cpp:
     10        (WebKit::WebDataSourceImpl::pageTitle):
     11        (WebKit::WebDataSourceImpl::pageTitleDirection):
     12        * src/WebDataSourceImpl.h:
     13
    1142011-04-20  Pavel Feldman  <pfeldman@google.com>
    215
  • trunk/Source/WebKit/chromium/public/WebDataSource.h

    r67676 r84400  
    3434#include "WebCommon.h"
    3535#include "WebNavigationType.h"
     36#include "WebTextDirection.h"
    3637
    3738namespace WebKit {
     
    7980    virtual WebString pageTitle() const = 0;
    8081
     82    // Returns the text direction of the title for the current page.
     83    virtual WebTextDirection pageTitleDirection() const = 0;
     84
    8185    // The type of navigation that triggered the creation of this datasource.
    8286    virtual WebNavigationType navigationType() const = 0;
  • trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp

    r82580 r84400  
    8383WebString WebDataSourceImpl::pageTitle() const
    8484{
    85     // FIXME: use direction of title as well.
    8685    return title().string();
     86}
     87
     88WebTextDirection WebDataSourceImpl::pageTitleDirection() const
     89{
     90    return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft;
    8791}
    8892
  • trunk/Source/WebKit/chromium/src/WebDataSourceImpl.h

    r67676 r84400  
    6464    virtual void redirectChain(WebVector<WebURL>&) const;
    6565    virtual WebString pageTitle() const;
     66    virtual WebTextDirection pageTitleDirection() const;
    6667    virtual WebNavigationType navigationType() const;
    6768    virtual double triggeringEventTime() const;
Note: See TracChangeset for help on using the changeset viewer.