Changeset 84429 in webkit

Timestamp:

Apr 20, 2011 3:57:42 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-20 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

[chromium] Move Chromium media controls into own root element.
​https://bugs.webkit.org/show_bug.cgi?id=59018

No new tests as there is no functional change

• WebCore.gypi:
• css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
• html/shadow/MediaControlRootElementChromium.cpp: Added. Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
• html/shadow/MediaControlRootElementChromium.h: Added.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• css/mediaControlsChromium.css (modified) (3 diffs)
• html/shadow/MediaControlRootElementChromium.cpp (added)
• html/shadow/MediaControlRootElementChromium.h (added)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-20  Steve Lacey  <sjl@chromium.org>
+
+        Reviewed by Eric Carlson.
+
+        [chromium] Move Chromium media controls into own root element.
+        https://bugs.webkit.org/show_bug.cgi?id=59018
+
+        No new tests as there is no functional change
+
+        * WebCore.gypi:
+        * css/mediaControlsChromium.css:
+        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
+        * html/shadow/MediaControlRootElementChromium.cpp: Added.
+        Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
+        * html/shadow/MediaControlRootElementChromium.h: Added.
+
 2011-04-20  Charlie Lee  <chocobo@chromium.org>
 

trunk/Source/WebCore/WebCore.gypi

@@ -3181 +3181 @@
             'html/shadow/MediaControlElements.cpp',
             'html/shadow/MediaControlElements.h',
-            'html/shadow/MediaControlRootElement.cpp',
-            'html/shadow/MediaControlRootElement.h',
+            'html/shadow/MediaControlRootElementChromium.cpp',
+            'html/shadow/MediaControlRootElementChromium.h',
             'html/shadow/MeterShadowElement.cpp',
             'html/shadow/MeterShadowElement.h',

trunk/Source/WebCore/css/mediaControlsChromium.css

@@ -77 +77 @@
     -webkit-box-align: center;
     -webkit-box-pack: center;
-    -webkit-box-direction: reverse;
     -webkit-box-flex: 1;
 
@@ -122 +121 @@
 }
 
-audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display {
-    -webkit-appearance: media-time-remaining-display;
-    -webkit-user-select: none;
-    display: none;
-    -webkit-box-flex: 0;
-    -webkit-box-pack: center;
-    -webkit-box-align: center;
-
-    overflow: hidden;
-    cursor: default;
-
-    line-height: 21px;
-    height: 20px;
-    width: 58px;
-
-    text-align: center;
-    font-family: Arial;
-    font-size: 16px;
-    font-weight: bold;
-    color: white;
-
-    letter-spacing: normal;
-    word-spacing: normal;
-    text-transform: none;
-    text-indent: 0;
-    text-shadow: none;
-    text-decoration: none;
-}
-
 audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline {
     -webkit-appearance: media-slider;
@@ -167 +137 @@
     background-color: rgba(255, 255, 255, 0.08);
     color: rgb(50, 140, 223);
-}
-
-audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button {
-    -webkit-appearance: media-seek-back-button;
-    display: none;
-}
-
-audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button {
-    -webkit-appearance: media-seek-forward-button;
-    display: none;
-}
-
-audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button {
-    -webkit-appearance: media-fullscreen-button;
-    display: none;
 }