Changeset 84434 in webkit


Ignore:
Timestamp:
Apr 20, 2011 4:41:52 PM (13 years ago)
Author:
mjs@apple.com
Message:

2011-04-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Reproducible crash under WebPageProxy::didReceiveEvent
https://bugs.webkit.org/show_bug.cgi?id=59036
<rdar://problem/9252083>

  • UIProcess/API/mac/WKView.mm: (-[WKView _resendKeyDownEvent:]): Protect against self-destruction when re-dispatching the event.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage): Fixed a type mismatch I noticed while debugging.
Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r84424 r84434  
     12011-04-20  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Reproducible crash under WebPageProxy::didReceiveEvent
     6        https://bugs.webkit.org/show_bug.cgi?id=59036
     7        <rdar://problem/9252083>
     8
     9        * UIProcess/API/mac/WKView.mm:
     10        (-[WKView _resendKeyDownEvent:]): Protect against self-destruction
     11        when re-dispatching the event.       
     12        * UIProcess/WebProcessProxy.cpp:
     13        (WebKit::WebProcessProxy::createWebPage): Fixed a type mismatch
     14        I noticed while debugging.
     15
    1162011-04-20  Timothy Hatcher  <timothy@apple.com>
    217
  • trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

    r84304 r84434  
    19881988- (void)_resendKeyDownEvent:(NSEvent *)event
    19891989{
     1990    // resending the event may destroy this WKView
     1991    RetainPtr<WKView> protect(self);
     1992
    19901993    ASSERT(!_data->_keyDownEventBeingResent);
    19911994    _data->_keyDownEventBeingResent = event;
  • trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp

    r84302 r84434  
    170170    ASSERT(context->process() == this);
    171171
    172     unsigned pageID = generatePageID();
     172    uint64_t pageID = generatePageID();
    173173    RefPtr<WebPageProxy> webPage = WebPageProxy::create(pageClient, this, pageGroup, pageID);
    174174    m_pageMap.set(pageID, webPage.get());
Note: See TracChangeset for help on using the changeset viewer.