Changeset 84440 in webkit

Timestamp:

Apr 20, 2011 5:23:28 PM (13 years ago)

Author:

Dimitri Glazkov

Message:

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
​https://bugs.webkit.org/show_bug.cgi?id=59037

• fast/events/simulated-click-disabled-expected.txt: Added.
• fast/events/simulated-click-disabled.html: Added.

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
​https://bugs.webkit.org/show_bug.cgi?id=59037

Test: fast/events/simulated-click-disabled.html

• dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/simulated-click-disabled-expected.txt (added)
• LayoutTests/fast/events/simulated-click-disabled.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/EventDispatcher.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
+        https://bugs.webkit.org/show_bug.cgi?id=59037
+
+        * fast/events/simulated-click-disabled-expected.txt: Added.
+        * fast/events/simulated-click-disabled.html: Added.
+
 2011-04-20  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
+        https://bugs.webkit.org/show_bug.cgi?id=59037
+
+        Test: fast/events/simulated-click-disabled.html
+
+        * dom/EventDispatcher.cpp:
+        (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
+
 2011-04-20  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/dom/EventDispatcher.cpp

@@ -100 +100 @@
 void EventDispatcher::dispatchSimulatedClick(Node* node, PassRefPtr<Event> underlyingEvent, bool sendMouseEvents, bool showPressedLook)
 {
+    if (node->disabled())
+        return;
+
     EventDispatcher dispatcher(node);