Changeset 84510 in webkit


Ignore:
Timestamp:
Apr 21, 2011 9:40:56 AM (13 years ago)
Author:
caseq@chromium.org
Message:

011-04-21 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
https://bugs.webkit.org/show_bug.cgi?id=59105

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatobject):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):
  • inspector/front-end/ResourceJSONView.js: (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/inspector/extensions/extensions.html

    r84499 r84510  
    6262        {
    6363            document.body.testProperty = 'foo';
    64             inspect(document.body);
    6564            return {
    6665                f0: 'expression',
     
    7877            };
    7978        }
    80         sidebar.setExpression("(" + expression.toString() + ")();", "title");
     79        // Do an extra round-trip to the inspected page to assure inspect()'s round-trip to
     80        // front-end is complete and $0 is properly updated with currently inspected node.
     81        webInspector.inspectedWindow.eval("", function() {
     82            sidebar.setExpression("(" + expression.toString() + ")();", "title");
     83        });
    8184    }
    82     webInspector.panels.elements.createSidebarPane("Watch Test: Expression", onSidebarCreated);
     85    webInspector.inspectedWindow.eval("inspect(document.body)", function() {
     86        webInspector.panels.elements.createSidebarPane("Watch Test: Expression", onSidebarCreated);
     87    });
    8388}
    8489
  • trunk/Source/WebCore/ChangeLog

    r84506 r84510  
     12011-04-21  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
     6        https://bugs.webkit.org/show_bug.cgi?id=59105
     7
     8        * inspector/front-end/ConsoleView.js:
     9        (WebInspector.ConsoleView.prototype._formatobject):
     10        * inspector/front-end/ExtensionPanel.js:
     11        (WebInspector.ExtensionSidebarPane.prototype._setObject):
     12        * inspector/front-end/ResourceJSONView.js:
     13        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
     14        * inspector/front-end/SourceFrame.js:
     15        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
     16        (WebInspector.SourceFrame.prototype._showPopup):
     17
    1182011-04-21  Adam Barth  <abarth@webkit.org>
    219
  • trunk/Source/WebCore/inspector/front-end/ConsoleView.js

    r83575 r84510  
    598598    _formatobject: function(obj, elem)
    599599    {
    600         elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, true).element);
     600        elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description).element);
    601601    },
    602602
  • trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js

    r84499 r84510  
    116116    {
    117117        this.bodyElement.removeChildren();
    118         var section = new WebInspector.ObjectPropertiesSection(object, title, null, true);
     118        var section = new WebInspector.ObjectPropertiesSection(object, title);
    119119        if (!title)
    120120            section.headerElement.addStyleClass("hidden");
  • trunk/Source/WebCore/inspector/front-end/ResourceJSONView.js

    r81878 r84510  
    6969
    7070        var obj = WebInspector.RemoteObject.fromLocalObject(this._parsedJSON);
    71         this.element.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, true).element);
     71        this.element.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description).element);
    7272    }
    7373}
  • trunk/Source/WebCore/inspector/front-end/SourceFrame.js

    r84494 r84510  
    825825                popupContentElement.appendChild(titleElement);
    826826
    827                 var section = new WebInspector.ObjectPropertiesSection(result, "", null, false);
     827                var section = new WebInspector.ObjectPropertiesSection(result);
    828828                section.expanded = true;
    829829                section.element.addStyleClass("source-frame-popover-tree");
Note: See TracChangeset for help on using the changeset viewer.