Changeset 84512 in webkit

Timestamp:

Apr 21, 2011 9:57:02 AM (13 years ago)

Author:

mdelaney@apple.com

Message:

2011-04-20 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <summary> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=58914

• Added test cases for dynamic DOM change.
• Updated expectations details-open2.html because generated RenderTree slightly changed.

• fast/html/details-add-summary-child-1.html: Added.
• fast/html/details-add-summary-child-2.html: Added.
• fast/html/details-remove-summary-child-1.html: Added.
• fast/html/details-remove-summary-child-2.html: Added.
• platform/chromium/test_expectations.txt:
• platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
• platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
• platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
• platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
• platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
• platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
• platform/mac/fast/html/details-open2-expected.txt:
• platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
• platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
• platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
• platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
• platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
• platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.

2011-04-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Maciej Stachowiak.

arc() should add a circle to the path when start and end angles are far enough apart
​https://bugs.webkit.org/show_bug.cgi?id=58934

Test: fast/canvas/canvas_arc_largeangles.html

• html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/canvas_arc_largeangles-expected.txt (added)
• LayoutTests/fast/canvas/canvas_arc_largeangles.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ -27 +27 @@
         * platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
         * platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.
+
+2011-04-20  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        arc() should add a circle to the path when start and end angles are far enough apart
+        https://bugs.webkit.org/show_bug.cgi?id=58934
+
+        * fast/canvas/canvas_arc_largeangles-expected.txt: Added.
+        * fast/canvas/canvas_arc_largeangles.html: Added.
 
 2011-04-20  Matthew Delaney  <mdelaney@apple.com>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-20  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        arc() should add a circle to the path when start and end angles are far enough apart
+        https://bugs.webkit.org/show_bug.cgi?id=58934
+
+        Test: fast/canvas/canvas_arc_largeangles.html
+
+        * html/canvas/CanvasRenderingContext2D.cpp:
+        (WebCore::CanvasRenderingContext2D::arc):
+
 2011-04-20  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp

@@ -852 +852 @@
     if (!state().m_invertibleCTM)
         return;
+
+    // If 'sa' and 'ea' differ by more than 2Pi, just add a circle starting/ending at 'sa'
+    if (anticlockwise && sa - ea >= 2 * piFloat) {
+        m_path.addArc(FloatPoint(x, y), r, sa, sa - 2 * piFloat, anticlockwise);
+        return;
+    }
+    if (!anticlockwise && ea - sa >= 2 * piFloat) {
+        m_path.addArc(FloatPoint(x, y), r, sa, sa + 2 * piFloat, anticlockwise);
+        return;
+    }
+
     m_path.addArc(FloatPoint(x, y), r, sa, ea, anticlockwise);
 }