Changeset 84574 in webkit


Ignore:
Timestamp:
Apr 21, 2011 5:33:21 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
  • src/EditorClientImpl.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): (WebCore::EditorClientQt::canPaste):
  • WebCoreSupport/EditorClientQt.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::canCopyCut): (WebKit::EditorClient::canPaste):
  • WebCoreSupport/EditorClientGtk.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):
  • WebCoreSupport/WebEditorClient.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::canCopyCut): (WebCore::EditorClientWx::canPaste):
  • WebKitSupport/EditorClientWx.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::canCopyCut): (WebCore::EditorClientHaiku::canPaste):
  • WebCoreSupport/EditorClientHaiku.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::canCopyCut): (WebCore::EditorClientEfl::canPaste):
  • WebCoreSupport/EditorClientEfl.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
This allows editor client to grant copy/cut and paste permissions per origin.

  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste):
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::canCopyCut): (WebCore::EmptyEditorClient::canPaste):
  • page/EditorClient.h:

2011-04-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::canCopyCut): (WebKit::WebEditorClient::canPaste):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
Location:
trunk/Source
Files:
31 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r84566 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
     9        This allows editor client to grant copy/cut and paste permissions per origin.
     10
     11        * editing/EditorCommand.cpp:
     12        (WebCore::supportedCopyCut):
     13        (WebCore::supportedPaste):
     14        * loader/EmptyClients.h:
     15        (WebCore::EmptyEditorClient::canCopyCut):
     16        (WebCore::EmptyEditorClient::canPaste):
     17        * page/EditorClient.h:
     18
    1192011-04-21  Oliver Hunt  <oliver@apple.com>
    220
  • trunk/Source/WebCore/editing/EditorCommand.cpp

    r83245 r84574  
    11321132
    11331133    EditorClient* client = frame->editor()->client();
    1134     return client ? client->canCopyCut(defaultValue) : defaultValue;
     1134    return client ? client->canCopyCut(frame, defaultValue) : defaultValue;
    11351135}
    11361136
     
    11441144
    11451145    EditorClient* client = frame->editor()->client();
    1146     return client ? client->canPaste(defaultValue) : defaultValue;
     1146    return client ? client->canPaste(frame, defaultValue) : defaultValue;
    11471147}
    11481148
  • trunk/Source/WebCore/loader/EmptyClients.h

    r84238 r84574  
    465465    virtual void clearUndoRedoOperations() { }
    466466
    467     virtual bool canCopyCut(bool defaultValue) const { return defaultValue; }
    468     virtual bool canPaste(bool defaultValue) const { return defaultValue; }
     467    virtual bool canCopyCut(Frame*, bool defaultValue) const { return defaultValue; }
     468    virtual bool canPaste(Frame*, bool defaultValue) const { return defaultValue; }
    469469    virtual bool canUndo() const { return false; }
    470470    virtual bool canRedo() const { return false; }
  • trunk/Source/WebCore/page/EditorClient.h

    r83344 r84574  
    109109    virtual void clearUndoRedoOperations() = 0;
    110110
    111     virtual bool canCopyCut(bool defaultValue) const = 0;
    112     virtual bool canPaste(bool defaultValue) const = 0;
     111    virtual bool canCopyCut(Frame*, bool defaultValue) const = 0;
     112    virtual bool canPaste(Frame*, bool defaultValue) const = 0;
    113113    virtual bool canUndo() const = 0;
    114114    virtual bool canRedo() const = 0;
  • trunk/Source/WebKit/chromium/ChangeLog

    r84520 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * src/EditorClientImpl.cpp:
     9        (WebKit::EditorClientImpl::canCopyCut):
     10        (WebKit::EditorClientImpl::canPaste):
     11        * src/EditorClientImpl.h:
     12
    1132011-04-21  Roland Steiner  <rolandsteiner@chromium.org>
    214
  • trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp

    r83617 r84574  
    321321}
    322322
    323 bool EditorClientImpl::canCopyCut(bool defaultValue) const
     323bool EditorClientImpl::canCopyCut(Frame*, bool defaultValue) const
    324324{
    325325    return defaultValue;
    326326}
    327327
    328 bool EditorClientImpl::canPaste(bool defaultValue) const
     328bool EditorClientImpl::canPaste(Frame*, bool defaultValue) const
    329329{
    330330    return defaultValue;
  • trunk/Source/WebKit/chromium/src/EditorClientImpl.h

    r82952 r84574  
    8080    virtual void registerCommandForRedo(PassRefPtr<WebCore::EditCommand>);
    8181    virtual void clearUndoRedoOperations();
    82     virtual bool canCopyCut(bool defaultValue) const;
    83     virtual bool canPaste(bool defaultValue) const;
     82    virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
     83    virtual bool canPaste(WebCore::Frame*, bool defaultValue) const;
    8484    virtual bool canUndo() const;
    8585    virtual bool canRedo() const;
  • trunk/Source/WebKit/efl/ChangeLog

    r84260 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/EditorClientEfl.cpp:
     9        (WebCore::EditorClientEfl::canCopyCut):
     10        (WebCore::EditorClientEfl::canPaste):
     11        * WebCoreSupport/EditorClientEfl.h:
     12
    1132011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
    214
  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

    r79953 r84574  
    161161}
    162162
    163 bool EditorClientEfl::canCopyCut(bool defaultValue) const
     163bool EditorClientEfl::canCopyCut(Frame*, bool defaultValue) const
    164164{
    165165    return defaultValue;
    166166}
    167167
    168 bool EditorClientEfl::canPaste(bool defaultValue) const
     168bool EditorClientEfl::canPaste(Frame*, bool defaultValue) const
    169169{
    170170    return defaultValue;
  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h

    r82952 r84574  
    8383    virtual void clearUndoRedoOperations();
    8484
    85     virtual bool canCopyCut(bool defaultValue) const;
    86     virtual bool canPaste(bool defaultValue) const;
     85    virtual bool canCopyCut(Frame*, bool defaultValue) const;
     86    virtual bool canPaste(Frame*, bool defaultValue) const;
    8787    virtual bool canUndo() const;
    8888    virtual bool canRedo() const;
  • trunk/Source/WebKit/gtk/ChangeLog

    r84540 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/EditorClientGtk.cpp:
     9        (WebKit::EditorClient::canCopyCut):
     10        (WebKit::EditorClient::canPaste):
     11        * WebCoreSupport/EditorClientGtk.h:
     12
    1132011-04-21  Martin Robinson  <mrobinson@igalia.com>
    214
  • trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp

    r79953 r84574  
    502502}
    503503
    504 bool EditorClient::canCopyCut(bool defaultValue) const
     504bool EditorClient::canCopyCut(WebCore::Frame*, bool defaultValue) const
    505505{
    506506    return defaultValue;
    507507}
    508508
    509 bool EditorClient::canPaste(bool defaultValue) const
     509bool EditorClient::canPaste(WebCore::Frame*, bool defaultValue) const
    510510{
    511511    return defaultValue;
  • trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h

    r79953 r84574  
    109109        virtual void clearUndoRedoOperations();
    110110
    111         virtual bool canCopyCut(bool defaultValue) const;
    112         virtual bool canPaste(bool defaultValue) const;
     111        virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
     112        virtual bool canPaste(WebCore::Frame*, bool defaultValue) const;
    113113        virtual bool canUndo() const;
    114114        virtual bool canRedo() const;
  • trunk/Source/WebKit/haiku/ChangeLog

    r82952 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/EditorClientHaiku.cpp:
     9        (WebCore::EditorClientHaiku::canCopyCut):
     10        (WebCore::EditorClientHaiku::canPaste):
     11        * WebCoreSupport/EditorClientHaiku.h:
     12
    1132011-04-04  MORITA Hajime  <morrita@google.com>
    214
  • trunk/Source/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp

    r82886 r84574  
    205205}
    206206
    207 bool EditorClientHaiku::canCopyCut(bool defaultValue) const
     207bool EditorClientHaiku::canCopyCut(WebCore::Frame*, bool defaultValue) const
    208208{
    209209    return defaultValue;
    210210}
    211211
    212 bool EditorClientHaiku::canPaste(bool defaultValue) const
     212bool EditorClientHaiku::canPaste(WebCore::Frame*, bool defaultValue) const
    213213{
    214214    return defaultValue;
  • trunk/Source/WebKit/haiku/WebCoreSupport/EditorClientHaiku.h

    r82952 r84574  
    8080        virtual void clearUndoRedoOperations();
    8181
    82         virtual bool canCopyCut(bool defaultValue) const;
    83         virtual bool canPaste(bool defaultValue) const;
     82        virtual bool canCopyCut(Frame*, bool defaultValue) const;
     83        virtual bool canPaste(Frame*, bool defaultValue) const;
    8484        virtual bool canUndo() const;
    8585        virtual bool canRedo() const;
  • trunk/Source/WebKit/mac/ChangeLog

    r84561 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/WebEditorClient.h:
     9        * WebCoreSupport/WebEditorClient.mm:
     10        (WebEditorClient::canCopyCut):
     11        (WebEditorClient::canPaste):
     12
    1132011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
    214
  • trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h

    r82952 r84574  
    108108    virtual void clearUndoRedoOperations();
    109109
    110     virtual bool canCopyCut(bool defaultValue) const;
    111     virtual bool canPaste(bool defaultValue) const;
     110    virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
     111    virtual bool canPaste(WebCore::Frame*, bool defaultValue) const;
    112112    virtual bool canUndo() const;
    113113    virtual bool canRedo() const;
  • trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

    r84220 r84574  
    573573}
    574574
    575 bool WebEditorClient::canCopyCut(bool defaultValue) const
     575bool WebEditorClient::canCopyCut(Frame*, bool defaultValue) const
    576576{
    577577    return defaultValue;
    578578}
    579579
    580 bool WebEditorClient::canPaste(bool defaultValue) const
     580bool WebEditorClient::canPaste(Frame*, bool defaultValue) const
    581581{
    582582    return defaultValue;
  • trunk/Source/WebKit/qt/ChangeLog

    r84501 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/EditorClientQt.cpp:
     9        (WebCore::EditorClientQt::canCopyCut):
     10        (WebCore::EditorClientQt::canPaste):
     11        * WebCoreSupport/EditorClientQt.h:
     12
    1132011-04-21  Yi Shen  <yi.4.shen@nokia.com>
    214
  • trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp

    r83305 r84574  
    260260}
    261261
    262 bool EditorClientQt::canCopyCut(bool defaultValue) const
     262bool EditorClientQt::canCopyCut(WebCore::Frame*, bool defaultValue) const
    263263{
    264264    return defaultValue;
    265265}
    266266
    267 bool EditorClientQt::canPaste(bool defaultValue) const
     267bool EditorClientQt::canPaste(WebCore::Frame*, bool defaultValue) const
    268268{
    269269    return defaultValue;
  • trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h

    r82952 r84574  
    8080    virtual void clearUndoRedoOperations();
    8181
    82     virtual bool canCopyCut(bool defaultValue) const;
    83     virtual bool canPaste(bool defaultValue) const;
     82    virtual bool canCopyCut(Frame*, bool defaultValue) const;
     83    virtual bool canPaste(Frame*, bool defaultValue) const;
    8484    virtual bool canUndo() const;
    8585    virtual bool canRedo() const;
  • trunk/Source/WebKit/win/ChangeLog

    r84435 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebCoreSupport/WebEditorClient.cpp:
     9        (WebEditorClient::canCopyCut):
     10        (WebEditorClient::canPaste):
     11        * WebCoreSupport/WebEditorClient.h:
     12
    1132011-04-20  Brent Fulgham  <bfulgham@webkit.org>
    214
  • trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp

    r84094 r84574  
    565565}
    566566
    567 bool WebEditorClient::canCopyCut(bool defaultValue) const
     567bool WebEditorClient::canCopyCut(Frame*, bool defaultValue) const
    568568{
    569569    return defaultValue;
    570570}
    571571
    572 bool WebEditorClient::canPaste(bool defaultValue) const
     572bool WebEditorClient::canPaste(Frame*, bool defaultValue) const
    573573{
    574574    return defaultValue;
  • trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h

    r82952 r84574  
    7979    void clearUndoRedoOperations();
    8080
    81     bool canCopyCut(bool defaultValue) const;
    82     bool canPaste(bool defaultValue) const;
     81    bool canCopyCut(Frame*, bool defaultValue) const;
     82    bool canPaste(Frame*, bool defaultValue) const;
    8383    bool canUndo() const;
    8484    bool canRedo() const;
  • trunk/Source/WebKit/wx/ChangeLog

    r83869 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebKitSupport/EditorClientWx.cpp:
     9        (WebCore::EditorClientWx::canCopyCut):
     10        (WebCore::EditorClientWx::canPaste):
     11        * WebKitSupport/EditorClientWx.h:
     12
    1132011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
    214
  • trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp

    r79953 r84574  
    314314}
    315315
    316 bool EditorClientWx::canCopyCut(bool defaultValue) const
     316bool EditorClientWx::canCopyCut(Frame*, bool defaultValue) const
    317317{
    318318    return defaultValue;
    319319}
    320320
    321 bool EditorClientWx::canPaste(bool defaultValue) const
     321bool EditorClientWx::canPaste(Frame*, bool defaultValue) const
    322322{
    323323    return defaultValue;
  • trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h

    r82952 r84574  
    8282    virtual void clearUndoRedoOperations();
    8383
    84     virtual bool canCopyCut(bool defaultValue) const;
    85     virtual bool canPaste(bool defaultValue) const;
     84    virtual bool canCopyCut(Frame*, bool defaultValue) const;
     85    virtual bool canPaste(Frame*, bool defaultValue) const;
    8686    virtual bool canUndo() const;
    8787    virtual bool canRedo() const;
  • trunk/Source/WebKit2/ChangeLog

    r84571 r84574  
     12011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Add Frame* to the argument lists of canCopyCut and canPaste
     6        https://bugs.webkit.org/show_bug.cgi?id=59153
     7
     8        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
     9        (WebKit::WebEditorClient::canCopyCut):
     10        (WebKit::WebEditorClient::canPaste):
     11        * WebProcess/WebCoreSupport/WebEditorClient.h:
     12
    1132011-04-21  Ivan Krstić  <ike@apple.com>
    214
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp

    r84304 r84574  
    244244}
    245245
    246 bool WebEditorClient::canCopyCut(bool defaultValue) const
     246bool WebEditorClient::canCopyCut(Frame*, bool defaultValue) const
    247247{
    248248    return defaultValue;
    249249}
    250250
    251 bool WebEditorClient::canPaste(bool defaultValue) const
     251bool WebEditorClient::canPaste(Frame*, bool defaultValue) const
    252252{
    253253    return defaultValue;
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h

    r82952 r84574  
    7676    virtual void clearUndoRedoOperations();
    7777
    78     virtual bool canCopyCut(bool defaultValue) const;
    79     virtual bool canPaste(bool defaultValue) const;
     78    virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
     79    virtual bool canPaste(WebCore::Frame*, bool defaultValue) const;
    8080    virtual bool canUndo() const;
    8181    virtual bool canRedo() const;
Note: See TracChangeset for help on using the changeset viewer.