Changeset 84614 in webkit
- Timestamp:
- Apr 22, 2011 3:04:50 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r84611 r84614 1 2011-04-22 Annie Sullivan <sullivan@chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Web Inspector: Timeline is too narrow 6 https://bugs.webkit.org/show_bug.cgi?id=58399 7 8 Changed Network Panel widths so that Timeline is 50%. 9 Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow. 10 11 * inspector/front-end/NetworkPanel.js: 12 (WebInspector.NetworkPanel.prototype._createTable): Changed column widths. 13 (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths. 14 (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values. 15 (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto 16 (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto 17 (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto 18 * inspector/front-end/utilities.js: 19 (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip. 20 1 21 2011-04-22 Dan Bernstein <mitz@apple.com> 2 22 -
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
r84492 r84614 157 157 columns.method.title = WebInspector.UIString("Method"); 158 158 columns.method.sortable = true; 159 columns.method.width = " 7%";159 columns.method.width = "6%"; 160 160 161 161 columns.status.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Status"), WebInspector.UIString("Text")); 162 162 columns.status.sortable = true; 163 columns.status.width = " 8%";163 columns.status.width = "6%"; 164 164 165 165 columns.type.title = WebInspector.UIString("Type"); 166 166 columns.type.sortable = true; 167 columns.type.width = " 10%";167 columns.type.width = "6%"; 168 168 169 169 columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Transfer")); 170 170 columns.size.sortable = true; 171 columns.size.width = " 10%";171 columns.size.width = "6%"; 172 172 columns.size.aligned = "right"; 173 173 174 174 columns.time.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Time"), WebInspector.UIString("Latency")); 175 175 columns.time.sortable = true; 176 columns.time.width = " 10%";176 columns.time.width = "6%"; 177 177 columns.time.aligned = "right"; 178 178 179 179 columns.timeline.title = ""; 180 180 columns.timeline.sortable = false; 181 columns.timeline.width = " 37%";181 columns.timeline.width = "50%"; 182 182 columns.timeline.sort = "ascending"; 183 183 … … 958 958 var widths = {}; 959 959 widths.name = 20; 960 widths.method = 7;961 widths.status = 8;962 widths.type = 10;963 widths.size = 10;964 widths.time = 10;965 widths.timeline = 37;960 widths.method = 6; 961 widths.status = 6; 962 widths.type = 6; 963 widths.size = 6; 964 widths.time = 6; 965 widths.timeline = 50; 966 966 } 967 967 … … 1466 1466 this._refreshNameCell(); 1467 1467 1468 this._methodCell. textContent = this._resource.requestMethod;1468 this._methodCell.setTextAndTitle(this._resource.requestMethod); 1469 1469 1470 1470 this._refreshStatusCell(); … … 1472 1472 if (this._resource.mimeType) { 1473 1473 this._typeCell.removeStyleClass("network-dim-cell"); 1474 this._typeCell. textContent = this._resource.mimeType;1474 this._typeCell.setTextAndTitle(this._resource.mimeType); 1475 1475 } else { 1476 1476 this._typeCell.addStyleClass("network-dim-cell"); 1477 this._typeCell. textContent = WebInspector.UIString("Pending");1477 this._typeCell.setTextAndTitle(WebInspector.UIString("Pending")); 1478 1478 } 1479 1479 … … 1536 1536 1537 1537 if (this._resource.failed) { 1538 if (this._resource.canceled) 1539 this._statusCell. textContent = WebInspector.UIString("(canceled)");1538 if (this._resource.canceled) 1539 this._statusCell.setTextAndTitle(WebInspector.UIString("(canceled)")); 1540 1540 else 1541 this._statusCell. textContent = WebInspector.UIString("(failed)");1541 this._statusCell.setTextAndTitle(WebInspector.UIString("(failed)")); 1542 1542 this._statusCell.addStyleClass("network-dim-cell"); 1543 1543 return; … … 1546 1546 var fromCache = this._resource.cached; 1547 1547 if (fromCache) { 1548 this._statusCell. textContent = WebInspector.UIString("(from cache)");1548 this._statusCell.setTextAndTitle(WebInspector.UIString("(from cache)")); 1549 1549 this._statusCell.addStyleClass("network-dim-cell"); 1550 1550 return; … … 1559 1559 } else { 1560 1560 if (this._resource.isDataURL() && this._resource.finished) 1561 this._statusCell. textContent = WebInspector.UIString("(data url)");1561 this._statusCell.setTextAndTitle(WebInspector.UIString("(data url)")); 1562 1562 else 1563 this._statusCell. textContent = WebInspector.UIString("Pending");1563 this._statusCell.setTextAndTitle(WebInspector.UIString("(Pending)")); 1564 1564 this._statusCell.addStyleClass("network-dim-cell"); 1565 1565 } … … 1571 1571 var transferSize = typeof this._resource.transferSize === "number" ? Number.bytesToString(this._resource.transferSize) : "?"; 1572 1572 var fromCache = this._resource.cached; 1573 this._sizeCell. textContent = !fromCache ? resourceSize : WebInspector.UIString("(from cache)");1573 this._sizeCell.setTextAndTitle(!fromCache ? resourceSize : WebInspector.UIString("(from cache)")); 1574 1574 if (fromCache) 1575 1575 this._sizeCell.addStyleClass("network-dim-cell"); … … 1584 1584 if (this._resource.duration > 0) { 1585 1585 this._timeCell.removeStyleClass("network-dim-cell"); 1586 this._timeCell. textContent = Number.secondsToString(this._resource.duration);1586 this._timeCell.setTextAndTitle(Number.secondsToString(this._resource.duration)); 1587 1587 this._appendSubtitle(this._timeCell, Number.secondsToString(this._resource.latency)); 1588 1588 } else { 1589 1589 this._timeCell.addStyleClass("network-dim-cell"); 1590 this._timeCell. textContent = WebInspector.UIString("Pending");1590 this._timeCell.setTextAndTitle(WebInspector.UIString("Pending")); 1591 1591 } 1592 1592 }, -
trunk/Source/WebCore/inspector/front-end/utilities.js
r84358 r84614 290 290 291 291 return elementOffset; 292 } 293 294 Element.prototype.setTextAndTitle = function(text) 295 { 296 this.textContent = text; 297 this.title = text; 292 298 } 293 299
Note: See TracChangeset
for help on using the changeset viewer.