Changeset 84624 in webkit


Ignore:
Timestamp:
Apr 22, 2011 6:36:51 AM (13 years ago)
Author:
caseq@chromium.org
Message:

2011-04-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194

  • inspector/front-end/ExtensionAPISchema.json:
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):

2011-04-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r84623 r84624  
     12011-04-22  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: [Extensions API] misc API cleanup
     6        https://bugs.webkit.org/show_bug.cgi?id=59194
     7
     8        * inspector/front-end/ExtensionAPISchema.json:
     9        * inspector/front-end/ExtensionPanel.js:
     10        (WebInspector.ExtensionSidebarPane.prototype._setObject):
     11
    1122011-04-21  Pavel Feldman  <pfeldman@google.com>
    213
  • trunk/Source/WebCore/inspector/front-end/ExtensionAPISchema.json

    r83033 r84624  
    2222                "name": "callback",
    2323                "type": "function",
    24                 "description": "A callback invoked when sidebar is created",
     24                "description": "A callback invoked when sidebar is created.",
    2525                "parameters": [
    2626                  {
    2727                    "name": "result",
    28                     "description": "An ExtensionSidebarPane object for created sidebar pane",
     28                    "description": "An ExtensionSidebarPane object for created sidebar pane.",
    2929                    "$ref": "ExtensionSidebarPane"
    3030                  }
     
    4343          {
    4444            "name": "onSelectionChanged",
    45             "description": "Fired when an objects is selected in the panel."
     45            "description": "Fired when an object is selected in the panel."
    4646          }
    4747        ]
     
    5151        "type": "object",
    5252        "isInstanceOf": "Panel",
    53         "description": "Represents a panel created by extension",
     53        "description": "Represents a panel created by extension.",
    5454        "events": [
    5555          {
     
    6666                "type": "string",
    6767                "optional": true,
    68                 "description": "Query string (only for 'performSearch')"
     68                "description": "Query string (only for 'performSearch')."
    6969              }
    7070            ]
     
    8585                "name": "height",
    8686                "type": "string",
    87                 "description": "A CSS-like size specification, e.g. '10px' or '12pt'"
     87                "description": "A CSS-like size specification, e.g. '10px' or '12pt'."
    8888              }
    8989            ]
     
    141141    ],
    142142    "properties": {
    143       "scripts": {
    144         "$ref": "ScriptsPanel",
    145         "description": "Scripts panel"
     143      "elements": {
     144        "$ref": "ElementsPanel",
     145        "description": "Elements panel."
    146146      }
    147147    },
     
    270270        "description": "Adds an audit category.",
    271271        "parameters": [
    272           { "name": "displayName", "type": "string", "description": "A display name for the category" },
     272          { "name": "displayName", "type": "string", "description": "A display name for the category." },
    273273          { "name": "resultCount", "type": "number", "description": "The expected number of audit results in the category." }
    274274        ],
     
    297297        "id": "FormattedValue",
    298298        "type": "object",
    299         "description": "A value returned from one of the formatters (an URL, code snippet etc), to be passed to createResult or addChild"
     299        "description": "A value returned from one of the formatters (an URL, code snippet etc), to be passed to createResult or addChild."
    300300      },
    301301      {
    302302        "id": "AuditResults",
    303303        "type": "object",
    304         "description": "A collection of audit results for current run of the audit category",
     304        "description": "A collection of audit results for current run of the audit category.",
    305305        "functions": [
    306306          {
     
    311311                "name": "displayName",
    312312                "type": "string",
    313                 "description": "A concise, high-level description of audit rule result"
     313                "description": "A concise, high-level description of audit rule result."
    314314              },
    315315              {
    316316                "name": "description",
    317317                "type": "string",
    318                 "description": "A detailed description of what the displayName means"
     318                "description": "A detailed description of what the displayName means."
    319319              },
    320320              {
     
    326326                "$ref": "AuditResultNode",
    327327                "optional": true,
    328                 "description": "A subtree that appears under added result that may provide additional details on the violations found"
     328                "description": "A subtree that appears under added result that may provide additional details on the violations found."
    329329              }
    330330            ]
     
    333333            "name": "createResult",
    334334            "type": "function",
    335             "description": "Creates a result node that may be user as details parameters to addResult",
     335            "description": "Creates a result node that may be user as details parameters to addResult.",
    336336            "parameters": [
    337337              {
     
    341341                  { "$ref": "FormattedValue" }
    342342                ],
    343                 "description": "Either string or formatted values returned by one of AuditResult formatters (url, snippet etc)"
     343                "description": "Either string or formatted values returned by one of AuditResult formatters (url, snippet etc)."
    344344              }
    345345            ],
     
    358358            "description": "Render passed value as an URL in the Audits panel",
    359359            "parameters": [
    360               { "name": "href", "type": "string", "description": "An URL that will appear as href value on resulting link" },
    361               { "name": "displayText", "type": "string", "description": "A text that will appear to user", "optional": true }
     360              { "name": "href", "type": "string", "description": "An URL that will appear as the href value on the resulting link." },
     361              { "name": "displayText", "type": "string", "description": "A text that will appear to the user.", "optional": true }
    362362            ],
    363363            "returns": { "$ref": "FormattedValue" }
     
    366366            "name": "snippet",
    367367            "type": "function",
    368             "description": "Render passed text as a code snippet in the Audits panel",
    369             "parameters": [
    370               { "name": "text", "type": "string", "description": "Snippet text" }
     368            "description": "Render passed text as a code snippet in the Audits panel.",
     369            "parameters": [
     370              { "name": "text", "type": "string", "description": "Snippet text." }
    371371            ],
    372372            "returns": { "$ref": "FormattedValue" }
     
    398398        "id": "AuditResultNode",
    399399        "type": "object",
    400         "description": "A node in the audit result trees. Displays some content and optionally has children node",
     400        "description": "A node in the audit result tree. Displays some content and optionally has children node.",
    401401        "functions": [
    402402          {
    403403            "name": "addChild",
    404             "description": "Adds another child node to this node",
     404            "description": "Adds another child node to this node.",
    405405            "parameters": [
    406406              {
     
    410410                  { "$ref": "FormattedValue" }
    411411                ],
    412                 "description": "Either string or formatted values returned by one of AuditResult formatters (url, snippet etc)"
     412                "description": "Either string or formatted values returned by one of AuditResult formatters (url, snippet etc)."
    413413              }
    414414            ],
     
    421421          "expanded": {
    422422            "type": "boolean",
    423             "description": "If set, the subtree will always be expanded"
     423            "description": "If set, the subtree will always be expanded."
    424424          }
    425425        }
  • trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js

    r84510 r84624  
    120120            section.headerElement.addStyleClass("hidden");
    121121        section.expanded = true;
     122        section.editable = false;
    122123        this.bodyElement.appendChild(section.element);
    123124        WebInspector.extensionServer.notifyExtensionSidebarUpdated(this._id);
  • trunk/Source/WebKit/chromium/ChangeLog

    r84593 r84624  
     12011-04-22  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: [Extensions API] misc API cleanup
     6        https://bugs.webkit.org/show_bug.cgi?id=59194
     7
     8        * src/js/DevTools.js:
     9        (WebInspector.platformExtensionAPI):
     10
    1112011-04-21  Chris Fleizach  <cfleizach@apple.com>
    212
  • trunk/Source/WebKit/chromium/src/js/DevTools.js

    r84358 r84624  
    172172    webInspector.inspectedWindow.__proto__.__defineGetter__("tabId", getTabId);
    173173    chrome = window.chrome || {};
    174     chrome.devTools = chrome.devTools || {};
     174    chrome.experimental = chrome.experimental || {};
     175    chrome.experimental.devtools = chrome.experimental.devtools || {};
    175176    for (var property in webInspector)
    176         chrome.devTools[property] = webInspector[property];
     177        chrome.experimental.devtools[property] = webInspector[property];
    177178}
    178179
Note: See TracChangeset for help on using the changeset viewer.