Changeset 84682 in webkit

Timestamp:

Apr 22, 2011 2:24:46 PM (13 years ago)

Author:

mitz@apple.com

Message:

Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.

Reviewed by Sam Weinig.

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/DrawingAreaImpl.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-22  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Paint the bounding rect of the dirty region instead of individual rectangles when the region
+        covers at least 3/4 of its bounds.
+
+        * WebProcess/WebPage/DrawingAreaImpl.cpp:
+        (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
+        achieve this actually works.
+
 2011-04-22  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp

@@ -525 +525 @@
 {
     const size_t rectThreshold = 10;
-    const float wastedSpaceThreshold = 0.75f;
+    const double wastedSpaceThreshold = 0.75;
 
     if (rects.size() <= 1 || rects.size() > rectThreshold)
@@ -538 +538 @@
         rectsArea += rects[i].width() * rects[i].height();
 
-    float wastedSpace = 1 - (rectsArea / boundsArea);
+    double wastedSpace = 1 - (static_cast<double>(rectsArea) / boundsArea);
 
     return wastedSpace <= wastedSpaceThreshold;