Changeset 84723 in webkit


Ignore:
Timestamp:
Apr 22, 2011 7:03:20 PM (13 years ago)
Author:
bweinstein@apple.com
Message:

WebKit2: Stop responsiveness timer before calling runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,

because runOpenPanel can spin a nested run loop.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r84721 r84723  
     12011-04-22  Brian Weinstein  <bweinstein@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        WebKit2: Stop responsiveness timer before calling runOpenPanel
     6        https://bugs.webkit.org/show_bug.cgi?id=59268
     7        <rdar://problem/9327944>
     8
     9        * UIProcess/WebPageProxy.cpp:
     10        (WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,
     11            because runOpenPanel can spin a nested run loop.
     12
    1132011-04-22  Chang Shu  <cshu@webkit.org>
    214
  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r84702 r84723  
    20672067    m_openPanelResultListener = WebOpenPanelResultListenerProxy::create(this);
    20682068
     2069    // Since runOpenPanel() can spin a nested run loop we need to turn off the responsiveness timer.
     2070    process()->responsivenessTimer()->stop();
     2071
    20692072    if (!m_uiClient.runOpenPanel(this, frame, data, m_openPanelResultListener.get()))
    20702073        didCancelForOpenPanel();
Note: See TracChangeset for help on using the changeset viewer.