Changeset 84729 in webkit

Timestamp:

Apr 22, 2011 8:09:13 PM (13 years ago)

Author:

Dimitri Glazkov

Message:

2011-04-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Change SVG-related shadow root checks to use isSVGShadowRoot.
​https://bugs.webkit.org/show_bug.cgi?id=59237

Covered by existing tests, no behavior change.

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
• svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
• svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSStyleSelector.cpp (modified) (1 diff)
• svg/SVGUseElement.cpp (modified) (1 diff)
• svg/animation/SVGSMILElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Change SVG-related shadow root checks to use isSVGShadowRoot.
+        https://bugs.webkit.org/show_bug.cgi?id=59237
+
+        Covered by existing tests, no behavior change.
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
+        * svg/SVGUseElement.cpp:
+        (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
+        * svg/animation/SVGSMILElement.cpp:
+        (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
+
 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -2231 +2231 @@
     // Spec: CSS2 selectors cannot be applied to the (conceptually) cloned DOM tree
     // because its contents are not part of the formal document structure.
-    if (e->isSVGElement() && e->isShadowRoot())
+    if (e->isSVGShadowRoot())
         return SelectorFailsCompletely;
 #endif

trunk/Source/WebCore/svg/SVGUseElement.cpp

@@ -516 +516 @@
     ContainerNode* parent = parentNode();
     while (parent) {
-        if (parent->isShadowRoot())
+        if (parent->isSVGShadowRoot())
             return;
 

trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp

@@ -172 +172 @@
     // Verify we are not in <use> instance tree.
     for (ContainerNode* n = this; n; n = n->parentNode())
-        ASSERT(!n->isShadowRoot());
+        ASSERT(!n->isSVGShadowRoot());
 #endif
     m_attributeName = constructQualifiedName(this, getAttribute(SVGNames::attributeNameAttr));