Changeset 84734 in webkit


Ignore:
Timestamp:
Apr 22, 2011 8:41:53 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • Source/WebKit.pro:

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • QtWebKit.pro:
  • symbian/platformplugin/WebPlugin.cpp: Removed.
  • symbian/platformplugin/WebPlugin.h: Removed.
  • symbian/platformplugin/platformplugin.pro: Removed.
  • symbian/platformplugin/qwebkitplatformplugin.h: Removed.

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
Location:
trunk
Files:
4 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r84627 r84734  
     12011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r84627.
     4        http://trac.webkit.org/changeset/84627
     5        https://bugs.webkit.org/show_bug.cgi?id=59271
     6
     7        It broke Symbian build (Requested by Ossy on #webkit).
     8
     9        * Source/WebKit.pro:
     10
    1112011-04-22  Yi Shen  <yi.4.shen@nokia.com>
    212

  • trunk/Source/WebKit.pro

    r84627 r84734  
    3333
    3434symbian {
    35     exists($$PWD/WebKit/qt/symbian/platformplugin): SUBDIRS += WebKit/qt/symbian/platformplugin
    36 
    3735    # Forward the install target to WebCore. A workaround since INSTALLS is not implemented for symbian
    3836    install.commands = $(MAKE) -C WebCore install

  • trunk/Source/WebKit/qt/ChangeLog

    r84644 r84734  
     12011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r84627.
     4        http://trac.webkit.org/changeset/84627
     5        https://bugs.webkit.org/show_bug.cgi?id=59271
     6
     7        It broke Symbian build (Requested by Ossy on #webkit).
     8
     9        * QtWebKit.pro:
     10        * symbian/platformplugin/WebPlugin.cpp: Removed.
     11        * symbian/platformplugin/WebPlugin.h: Removed.
     12        * symbian/platformplugin/platformplugin.pro: Removed.
     13        * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
     14
    1152011-04-22  Sam Weinig  <sam@webkit.org>
    216

  • trunk/Source/WebKit/qt/QtWebKit.pro

    r84627 r84734  
    124124    }
    125125
    126     platformplugin.sources = $$OUTPUT_DIR/plugins/QtWebKit/platformplugin$${QT_LIBINFIX}.dll
    127     platformplugin.path = c:$$QT_PLUGINS_BASE_DIR/QtWebKit
    128 
    129     DEPLOYMENT += webkitsisheader webkitlibs webkitbackup platformplugin
     126    DEPLOYMENT += webkitsisheader webkitlibs webkitbackup
    130127    !CONFIG(production):CONFIG-=def_files
    131128

  • trunk/Tools/ChangeLog

    r84730 r84734  
     12011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r84627.
     4        http://trac.webkit.org/changeset/84627
     5        https://bugs.webkit.org/show_bug.cgi?id=59271
     6
     7        It broke Symbian build (Requested by Ossy on #webkit).
     8
     9        * Scripts/webkitpy/style/checker.py:
     10        * Scripts/webkitpy/style/checker_unittest.py:
     11
    1122011-04-22  Dirk Pranke  <dpranke@chromium.org>
    213

  • trunk/Tools/Scripts/webkitpy/style/checker.py

    r84627 r84734  
    199199      "+pep8/W291",  # Trailing white space
    200200      "+whitespace/carriage_return"]),
    201 
    202     ([# Qt Symbian platform plugin has no config.h or header guard.
    203       # Qt code uses '_' in some places (such as private slots
    204       # and on test xxx_data methos on tests).
    205       "Source/WebKit/qt/symbian/platformplugin/"],
    206      ["-readability/naming",
    207       "-build/header_guard",
    208       "-build/include_order"]),
    209201]
    210202

  • trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

    r84627 r84734  
    238238        assertCheck("Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp",
    239239                    "readability/braces")
    240         assertCheck("Source/WebKit/qt/symbian/platformplugin/WebPlugin.cpp",
    241                     "readability/braces")
    242240        assertNoCheck("Source/JavaScriptCore/qt/api/qscriptengine.cpp",
    243241                      "readability/naming")
    … …  
    253251        assertNoCheck("Source/WebKit/qt/examples/platformplugin/WebPlugin.cpp",
    254252                      "readability/naming")
    255         assertNoCheck("Source/WebKit/qt/symbian/platformplugin/WebPlugin.cpp",
    256                       "build/header_guard")
    257253
    258254        assertNoCheck("Tools/MiniBrowser/qt/UrlLoader.cpp",
Note: See TracChangeset for help on using the changeset viewer.