Changeset 84778 in webkit

Timestamp:

Apr 25, 2011 9:39:08 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-04-25 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] Should be easy to copy data.
​https://bugs.webkit.org/show_bug.cgi?id=45662

Adds context menu items to copy resource location, resource request headers, and resource response headers.

• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
• inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/NetworkPanel.js (modified) (2 diffs)
• inspector/front-end/Resource.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-25  Annie Sullivan  <sullivan@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [Resources panel] Should be easy to copy data.
+        https://bugs.webkit.org/show_bug.cgi?id=45662
+
+        Adds context menu items to copy resource location, resource request headers, and resource response headers.
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
+        (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
+        (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
+        (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
+        * inspector/front-end/Resource.js:
+        (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
+        (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
+
 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -1002 +1002 @@
         var resource = gridNode && gridNode._resource;
 
-        if (resource)
+        if (resource) {
+            contextMenu.appendItem(WebInspector.UIString("Copy location"), this._copyLocation.bind(this, resource));
+            if (resource.requestHeadersText)
+                contextMenu.appendItem(WebInspector.UIString("Copy request headers"), this._copyRequestHeaders.bind(this, resource));
+            if (resource.responseHeadersText)
+                contextMenu.appendItem(WebInspector.UIString("Copy response headers"), this._copyResponseHeaders.bind(this, resource));
             contextMenu.appendItem(WebInspector.UIString("Copy entry as HAR"), this._copyResource.bind(this, resource));
+        }
         contextMenu.appendItem(WebInspector.UIString("Copy all as HAR"), this._copyAll.bind(this));
 
@@ -1028 +1034 @@
         var har = (new WebInspector.HAREntry(resource)).build();
         InspectorFrontendHost.copyText(JSON.stringify(har));
+    },
+
+    _copyLocation: function(resource)
+    {
+        InspectorFrontendHost.copyText(resource.url);
+    },
+
+    _copyRequestHeaders: function(resource)
+    {
+        InspectorFrontendHost.copyText(resource.requestHeadersText);
+    },
+
+    _copyResponseHeaders: function(resource)
+    {
+        InspectorFrontendHost.copyText(resource.responseHeadersText);
     },
 

trunk/Source/WebCore/inspector/front-end/Resource.js

@@ -436 +436 @@
     get requestHeadersText()
     {
+        if (this._requestHeadersText !== undefined)
+            return this._requestHeadersText;
+
+        this._requestHeadersText = "";
+        for (var key in this.requestHeaders)
+            this._requestHeadersText += key + ": " + this.requestHeaders[key] + "\n"; 
         return this._requestHeadersText;
     },
@@ -511 +517 @@
     get responseHeadersText()
     {
+        if (this._responseHeadersText !== undefined)
+            return this._responseHeadersText;
+        
+        this._responseHeadersText = "";
+        for (var key in this.responseHeaders)
+            this._responseHeadersText += key + ": " + this.responseHeaders[key] + "\n"; 
         return this._responseHeadersText;
     },