Changeset 84824 in webkit

Timestamp:

Apr 25, 2011 4:09:56 PM (13 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: Web Inspector's style sidebar fails to display when inspecting element
​https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>

Reviewed by Timothy Hatcher.

When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width

and height.

• UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WebInspectorProxyMac.mm (modified) (1 diff)
• UIProcess/win/WebInspectorProxyWin.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-25  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Timothy Hatcher.
+
+        WebKit2: Web Inspector's style sidebar fails to display when inspecting element
+        https://bugs.webkit.org/show_bug.cgi?id=58071
+        <rdar://problem/9243093>
+        
+        When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
+        with the empty rect for their initial size. Before we sized them correctly, the inspector
+        was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.
+
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
+            and height.
+        * UIProcess/win/WebInspectorProxyWin.cpp:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.
+
 2011-04-25  Brian Weinstein  <bweinstein@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm

@@ -83 +83 @@
     ASSERT(!m_inspectorView);
 
-    m_inspectorView.adoptNS([[WKView alloc] initWithFrame:NSZeroRect contextRef:toAPI(page()->process()->context()) pageGroupRef:toAPI(inspectorPageGroup())]);
+    m_inspectorView.adoptNS([[WKView alloc] initWithFrame:NSMakeRect(0, 0, initialWindowWidth, initialWindowHeight) contextRef:toAPI(page()->process()->context()) pageGroupRef:toAPI(inspectorPageGroup())]);
     ASSERT(m_inspectorView);
 

trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp

@@ -188 +188 @@
     ASSERT(!m_inspectorWindow);
 
-    RECT emptyRect = { 0 };
-    m_inspectorView = WebView::create(emptyRect, m_page->process()->context(), inspectorPageGroup(), 0);
+    RECT initialRect = { 0, 0, initialWindowWidth, initialWindowHeight };
+    m_inspectorView = WebView::create(initialRect, m_page->process()->context(), inspectorPageGroup(), 0);
 
     return m_inspectorView->page();