Changeset 84841 in webkit

Timestamp:

Apr 25, 2011 4:43:04 PM (13 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: Should be able to inspect Web Inspector in Debug Builds
​https://bugs.webkit.org/show_bug.cgi?id=59378

Reviewed by Adam Roben.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Creates an inspector page group and enables

developer extras in a debug build.

(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebInspectorProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-25  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Adam Roben.
+
+        WebKit2: Should be able to inspect Web Inspector in Debug Builds
+        https://bugs.webkit.org/show_bug.cgi?id=59378
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::createInspectorPageGroup): Creates an inspector page group and enables
+            developer extras in a debug build.
+        (WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.
+
 2011-04-25  Brian Weinstein  <bweinstein@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp

@@ -32 +32 @@
 #include "WebPageProxy.h"
 #include "WebPageCreationParameters.h"
+#include "WebPreferences.h"
 #include "WebProcessProxy.h"
 #include "WebPageGroup.h"
@@ -45 +46 @@
 namespace WebKit {
 
+static PassRefPtr<WebPageGroup> createInspectorPageGroup()
+{
+    RefPtr<WebPageGroup> pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false);
+
+#ifndef NDEBUG
+    // Allow developers to inspect the Web Inspector in debug builds.
+    pageGroup->preferences()->setDeveloperExtrasEnabled(true);
+#endif
+
+    return pageGroup.release();
+}
+
 WebPageGroup* WebInspectorProxy::inspectorPageGroup()
 {
-    static WebPageGroup* pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef();
+    static WebPageGroup* pageGroup = createInspectorPageGroup().leakRef();
     return pageGroup;
 }