Changeset 84846 in webkit


Ignore:
Timestamp:
Apr 25, 2011 4:54:38 PM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-04-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

JavaScriptCore should play nice strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59401

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
  • heap/Heap.cpp: (JSC::TypeCounter::TypeCounter):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope):
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
Location:
trunk/Source/JavaScriptCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r84825 r84846  
     12011-04-25  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        JavaScriptCore should play nice strict OwnPtrs
     6        https://bugs.webkit.org/show_bug.cgi?id=59401
     7
     8        * dfg/DFGByteCodeParser.cpp:
     9        (JSC::DFG::ByteCodeParser::parse):
     10        * heap/Heap.cpp:
     11        (JSC::TypeCounter::TypeCounter):
     12        * jit/JITStubs.cpp:
     13        (JSC::JITThunks::JITThunks):
     14        * parser/JSParser.cpp:
     15        (JSC::JSParser::Scope::Scope):
     16        * yarr/YarrJIT.cpp:
     17        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
     18
    1192011-04-25  Mark Rowe  <mrowe@apple.com>
    220
  • trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

    r84821 r84846  
    11061106        // Loop until we reach the current limit (i.e. next jump target).
    11071107        do {
    1108             m_currentBlock = new BasicBlock(m_currentIndex, m_graph.size(), m_numArguments, m_numLocals);
    1109             m_graph.m_blocks.append(m_currentBlock);
     1108            OwnPtr<BasicBlock> block = adoptPtr(new BasicBlock(m_currentIndex, m_graph.size(), m_numArguments, m_numLocals));
     1109            m_currentBlock = block.get();
     1110            m_graph.m_blocks.append(block.release());
    11101111
    11111112            if (!parseBlock(limit))
  • trunk/Source/JavaScriptCore/heap/Heap.cpp

    r84660 r84846  
    317317
    318318inline TypeCounter::TypeCounter()
    319     : m_typeCountSet(new TypeCountSet)
     319    : m_typeCountSet(adoptPtr(new TypeCountSet))
    320320{
    321321}
  • trunk/Source/JavaScriptCore/jit/JITStubs.cpp

    r84052 r84846  
    753753
    754754JITThunks::JITThunks(JSGlobalData* globalData)
    755     : m_hostFunctionStubMap(new HostFunctionStubMap)
     755    : m_hostFunctionStubMap(adoptPtr(new HostFunctionStubMap))
    756756{
    757757    if (!globalData->executableAllocator.isValid())
  • trunk/Source/JavaScriptCore/parser/JSParser.cpp

    r83637 r84846  
    292292            , m_loopDepth(0)
    293293            , m_switchDepth(0)
    294             , m_labels(0)
    295294        {
    296295        }
     
    308307            , m_loopDepth(rhs.m_loopDepth)
    309308            , m_switchDepth(rhs.m_switchDepth)
    310             , m_labels(0)
    311309        {
    312310            if (rhs.m_labels) {
  • trunk/Source/JavaScriptCore/yarr/YarrJIT.cpp

    r82617 r84846  
    418418        ParenthesesTail* addParenthesesTail(PatternTerm& term, JumpList* jumpListToPriorParen)
    419419        {
    420             ParenthesesTail* parenthesesTail = new ParenthesesTail(term, m_parenNestingLevel, jumpListToPriorParen);
    421             m_parenTails.append(parenthesesTail);
    422             m_parenTailsForIteration.append(parenthesesTail);
    423 
    424             return parenthesesTail;
     420            OwnPtr<ParenthesesTail> tail = adoptPtr(new ParenthesesTail(term, m_parenNestingLevel, jumpListToPriorParen));
     421            ParenthesesTail* rawTail = tail.get();
     422
     423            m_parenTails.append(tail.release());
     424            m_parenTailsForIteration.append(rawTail);
     425
     426            return rawTail;
    425427        }
    426428
Note: See TracChangeset for help on using the changeset viewer.