Changeset 84871 in webkit

Timestamp:

Apr 25, 2011 8:14:21 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84864.
​http://trac.webkit.org/changeset/84864
​https://bugs.webkit.org/show_bug.cgi?id=59413

Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).

• svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
• svg/custom/use-crash-in-non-wellformed-document.svg: Removed.

2011-04-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84864.
​http://trac.webkit.org/changeset/84864
​https://bugs.webkit.org/show_bug.cgi?id=59413

Expect result of use-crash-in-non-wellformed-document.svg is
platform dependent (Requested by leoyang on #webkit).

• svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/use-crash-in-non-wellformed-document-expected.txt (deleted)
• LayoutTests/svg/custom/use-crash-in-non-wellformed-document.svg (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGUseElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r84864.
+        http://trac.webkit.org/changeset/84864
+        https://bugs.webkit.org/show_bug.cgi?id=59413
+
+        Expect result of use-crash-in-non-wellformed-document.svg is
+        platform dependent (Requested by leoyang on #webkit).
+
+        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
+        * svg/custom/use-crash-in-non-wellformed-document.svg: Removed.
+
 2011-04-25  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r84864.
+        http://trac.webkit.org/changeset/84864
+        https://bugs.webkit.org/show_bug.cgi?id=59413
+
+        Expect result of use-crash-in-non-wellformed-document.svg is
+        platform dependent (Requested by leoyang on #webkit).
+
+        * svg/SVGUseElement.cpp:
+        (WebCore::SVGUseElement::insertedIntoDocument):
+
 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
 

trunk/Source/WebCore/svg/SVGUseElement.cpp

@@ -128 +128 @@
 }
 
-static inline bool isWellFormedDocument(Document* document)
-{
-    if (document->isSVGDocument() || document->isXHTMLDocument())
-        return static_cast<XMLDocumentParser*>(document->parser())->wellFormed();
-    return true;
-}
-
 void SVGUseElement::insertedIntoDocument()
 {
     // This functions exists to assure assumptions made in the code regarding SVGElementInstance creation/destruction are satisfied.
     SVGStyledTransformableElement::insertedIntoDocument();
-    ASSERT(!m_targetElementInstance || !isWellFormedDocument(document()));
-    ASSERT(!m_isPendingResource || !isWellFormedDocument(document()));
+    ASSERT(!m_targetElementInstance || ((document()->isSVGDocument() || document()->isXHTMLDocument()) && !static_cast<XMLDocumentParser*>(document()->parser())->wellFormed()));
+    ASSERT(!m_isPendingResource);
 }