Changeset 84912 in webkit

Timestamp:

Apr 26, 2011 7:47:15 AM (13 years ago)

Author:

mihaip@chromium.org

Message:

2011-04-26 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Fix timestamp comparison in check-for-weak-vtables-and-externals
​https://bugs.webkit.org/show_bug.cgi?id=59416

We should only re-run the check-for-weak-vtables-and-externals script
if the executable is more recent than the last run.

• Scripts/check-for-weak-vtables-and-externals:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/check-for-weak-vtables-and-externals (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-26  Mihai Parparita  <mihaip@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix timestamp comparison in check-for-weak-vtables-and-externals
+        https://bugs.webkit.org/show_bug.cgi?id=59416
+        
+        We should only re-run the check-for-weak-vtables-and-externals script
+        if the executable is more recent than the last run.
+
+        * Scripts/check-for-weak-vtables-and-externals:
+
 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
 

trunk/Tools/Scripts/check-for-weak-vtables-and-externals

@@ -57 +57 @@
 my $sawError = 0;
 
-if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge > $buildTimestampAge) {
+if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge < $buildTimestampAge) {
     if (!open NM, "(nm -m '$executablePath' | c++filt | sed 's/^/STDOUT:/') 2>&1 |") {
         print "ERROR: Could not open $executablePath\n";