Changeset 84975 in webkit


Ignore:
Timestamp:
Apr 26, 2011 4:20:39 PM (13 years ago)
Author:
mario@webkit.org
Message:

2011-04-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] accessibility/aria-combobox-expected.txt
​https://bugs.webkit.org/show_bug.cgi?id=59399

Unskip the test and provide expectations for Mac and GTK.

  • accessibility/aria-combobox.html: Do not check roles to be the right ones, print them and leave the check for the expected file.
  • platform/gtk/Skipped: Unskip the test.
  • platform/gtk/accessibility/aria-combobox-expected.txt: New.
  • platform/mac/accessibility/aria-combobox-expected.txt: Updated.

2011-04-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] accessibility/aria-combobox-expected.txt
​https://bugs.webkit.org/show_bug.cgi?id=59399

Implement isExpanded(), as it's used in the layout test.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): Implemented.
Location:
trunk
Files:
6 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r84966 r84975  
     12011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [GTK] accessibility/aria-combobox-expected.txt
     6        https://bugs.webkit.org/show_bug.cgi?id=59399
     7
     8        Unskip the test and provide expectations for Mac and GTK.
     9
     10        * accessibility/aria-combobox.html: Do not check roles to be the
     11        right ones, print them and leave the check for the expected file.
     12        * platform/gtk/Skipped: Unskip the test.
     13        * platform/gtk/accessibility/aria-combobox-expected.txt: New.
     14        * platform/mac/accessibility/aria-combobox-expected.txt: Updated.
     15
    1162011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
    217

  • trunk/LayoutTests/accessibility/aria-combobox.html

    r84600 r84975  
    3232          combobox = accessibilityController.focusedElement;
    3333
    34           shouldBe("combobox.role", "'AXRole: AXComboBox'");
     34          debug("Role: " + combobox.role);
    3535          shouldBe("combobox.isExpanded", "false");
    3636   
    … …  
    4141
    4242          var firstChild = combobox.childAtIndex(0);
    43           shouldBe("firstChild.role", "'AXRole: AXList'");
     43          debug("Role: " + firstChild.role);
    4444    }
    4545

  • trunk/LayoutTests/platform/gtk/Skipped

    r84966 r84975  
    325325# TESTS FAILING
    326326###############################################################################
    327 accessibility/aria-combobox.html
    328327accessibility/aria-help.html
    329328accessibility/aria-hidden.html

  • trunk/LayoutTests/platform/gtk/accessibility/aria-combobox-expected.txt

    r84974 r84975  
    66
    77
    8 PASS combobox.role is 'AXRole: AXComboBox'
     8Role: AXRole: combo box
    99PASS combobox.isExpanded is false
    1010PASS combobox.isExpanded is false
    11 PASS firstChild.role is 'AXRole: AXList'
     11Role: AXRole: list
    1212PASS successfullyParsed is true
    1313

  • trunk/LayoutTests/platform/mac/accessibility/aria-combobox-expected.txt

    r84600 r84975  
    66
    77
    8 PASS combobox.role is 'AXRole: AXComboBox'
     8Role: AXRole: AXComboBox
    99PASS combobox.isExpanded is false
    1010PASS combobox.isExpanded is false
    11 PASS firstChild.role is 'AXRole: AXList'
     11Role: AXRole: AXList
    1212PASS successfullyParsed is true
    1313

  • trunk/Tools/ChangeLog

    r84973 r84975  
     12011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [GTK] accessibility/aria-combobox-expected.txt
     6        https://bugs.webkit.org/show_bug.cgi?id=59399
     7
     8        Implement isExpanded(), as it's used in the layout test.
     9
     10        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
     11        (AccessibilityUIElement::isExpanded): Implemented.
     12
    1132011-04-26  Adrienne Walker  <enne@google.com>
    214

  • trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

    r84966 r84975  
    437437bool AccessibilityUIElement::isExpanded() const
    438438{
    439     // FIXME: implement
    440     return false;
     439    if (!ATK_IS_OBJECT(m_element))
     440        return false;
     441
     442    GRefPtr<AtkStateSet> stateSet = adoptGRef(atk_object_ref_state_set(ATK_OBJECT(m_element)));
     443    gboolean isExpanded = atk_state_set_contains_state(stateSet.get(), ATK_STATE_EXPANDED);
     444
     445    return isExpanded;
    441446}
    442447
Note: See TracChangeset for help on using the changeset viewer.