Changeset 84999 in webkit


Ignore:
Timestamp:
Apr 26, 2011 6:28:10 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-26 Dinesh K Garg <​dineshg@codeaurora.org>

Reviewed by Eric Seidel.

Test case for: beginElement broken by setAttribute
​https://bugs.webkit.org/show_bug.cgi?id=26019

  • svg/animations/animate-beginElementAt-expected.txt: Added.
  • svg/animations/animate-beginElementAt.svg: Added.
  • svg/animations/animate-dynamic-update-attributeName-expected.txt: Nice side effect of the patch, we are now fully passing this test.

2011-04-26 Dinesh K Garg <​dineshg@codeaurora.org>

Reviewed by Eric Seidel.

beginElement broken by setAttribute
​https://bugs.webkit.org/show_bug.cgi?id=26019

Test: svg/animations/animate-beginElementAt.svg

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::attributeChanged): Reset the animation state here as the rest of the code reads it and would still think we are animating when we are not.
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r84998 r84999  
     12011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Test case for: beginElement broken by setAttribute
     6        https://bugs.webkit.org/show_bug.cgi?id=26019
     7
     8        * svg/animations/animate-beginElementAt-expected.txt: Added.
     9        * svg/animations/animate-beginElementAt.svg: Added.
     10        * svg/animations/animate-dynamic-update-attributeName-expected.txt:
     11        Nice side effect of the patch, we are now fully passing this test.
     12
    1132011-04-26  Geoffrey Garen  <ggaren@apple.com>
    214

  • trunk/LayoutTests/svg/animations/animate-dynamic-update-attributeName-expected.txt

    r79675 r84999  
    77
    88PASS rect.style.color is 'rgb(0, 128, 0)'
    9 FAIL rect.style.fill should be #008000. Was #ff0000.
     9PASS rect.style.fill is '#008000'
    1010PASS successfullyParsed is true
    1111

  • trunk/Source/WebCore/ChangeLog

    r84996 r84999  
     12011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        beginElement broken by setAttribute
     6        https://bugs.webkit.org/show_bug.cgi?id=26019
     7
     8        Test: svg/animations/animate-beginElementAt.svg
     9
     10        * svg/SVGAnimationElement.cpp:
     11        (WebCore::SVGAnimationElement::attributeChanged):
     12        Reset the animation state here as the rest of the code reads it and would still
     13        think we are animating when we are not.
     14
     15        * svg/animation/SVGSMILElement.h:
     16        (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
     17
    1182011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
    219

  • trunk/Source/WebCore/svg/SVGAnimationElement.cpp

    r79155 r84999  
    162162    // Assumptions may not hold after an attribute change.
    163163    m_animationValid = false;
     164    setInactive();
    164165    SVGSMILElement::attributeChanged(attr, preserveDecls);
    165166}

  • trunk/Source/WebCore/svg/animation/SVGSMILElement.h

    r79569 r84999  
    112112    void addEndTime(SMILTime);
    113113
     114    void setInactive() { m_activeState = Inactive; }
     115
    114116private:
    115117    virtual void startedActiveInterval() = 0;
Note: See TracChangeset for help on using the changeset viewer.