Changeset 85015 in webkit

Timestamp:

Apr 26, 2011 10:07:27 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-26 Ami Fischman <​fischman@google.com>

Reviewed by David Levin.

Fix media/video-controls-transformed.html layouttest to compute the click
location of the play button instead of hard-coding pixel values that have
been wrong for a long time. Start expecting the test to pass in chromium
(it's currently Skipped on all platforms).
​https://bugs.webkit.org/show_bug.cgi?id=58590

• media/video-controls-transformed.html:
• platform/chromium/test_expectations.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/video-controls-transformed.html (modified) (1 diff)
• platform/chromium/test_expectations.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-26  Ami Fischman  <fischman@google.com>
+
+        Reviewed by David Levin.
+
+        Fix media/video-controls-transformed.html layouttest to compute the click
+        location of the play button instead of hard-coding pixel values that have
+        been wrong for a long time.  Start expecting the test to pass in chromium
+        (it's currently Skipped on all platforms).
+        https://bugs.webkit.org/show_bug.cgi?id=58590
+
+        * media/video-controls-transformed.html:
+        * platform/chromium/test_expectations.txt:
+
 2011-04-26  Dirk Pranke  <dpranke@chromium.org>
 

trunk/LayoutTests/media/video-controls-transformed.html

@@ -18 +18 @@
         testExpected("video.controls", null, '!=');
         waitForEvent('canplaythrough', function () {
-            if (window.eventSender) 
-            {
-                eventSender.mouseMoveTo(54,240); // over play button
+            if (window.eventSender) {
+                // Find the play button and click the middle of its bounding box.
+                // This approach hard-codes the construction order of the media
+                // controls, which is ugly, but sadly is also currently the only
+                // way to do it.
+                // http://bugs.webkit.org/show_bug.cgi?id=58584 is tracking fixing that.
+                var playButton = layoutTestController.shadowRoot(video).firstChild.firstChild.children[1];
+                if (!playButton) {
+                    failTest("Failed to find play/pause button.");
+                }
+                var playButtonBoundingRect = playButton.getBoundingClientRect();
+                var clickX = playButtonBoundingRect.left + playButtonBoundingRect.width / 2;
+                var clickY = playButtonBoundingRect.top + playButtonBoundingRect.height / 2;
+                eventSender.mouseMoveTo(clickX, clickY);
                 eventSender.mouseDown();
                 eventSender.mouseUp();

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -822 +822 @@
 // KNOWNISSUE : fails because progress event is not published 
 BUGCR59675 BUGCR59263 SKIP : media/event-attributes.html = PASS FAIL TIMEOUT
-
-// These tests are failing because they use position-dependent mouse clicks.
-// might be hard to fix
-BUGCR25375 : media/video-controls-transformed.html = FAIL
 
 // We haven't implemented the WebKit fullscreen extension.