Changeset 85020 in webkit
- Timestamp:
- Apr 26, 2011 11:08:32 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r85017 r85020 1 2011-04-26 David Levin <levin@chromium.org> 2 3 Reviewed by Eric Seidel. 4 5 Fix some strict PassOwnPtr issues in WebCore. 6 https://bugs.webkit.org/show_bug.cgi?id=59563 7 8 * css/SVGCSSStyleSelector.cpp: 9 (WebCore::CSSStyleSelector::applySVGProperty): 10 * html/canvas/WebGLRenderingContext.cpp: 11 (WebCore::WebGLRenderingContext::create): 12 (WebCore::WebGLRenderingContext::~WebGLRenderingContext): 13 * platform/text/TextCodecLatin1.cpp: 14 (WebCore::newStreamingTextDecoderWindowsLatin1): 15 * platform/text/TextCodecUTF16.cpp: 16 (WebCore::newStreamingTextDecoderUTF16LE): 17 (WebCore::newStreamingTextDecoderUTF16BE): 18 * platform/text/TextCodecUserDefined.cpp: 19 (WebCore::newStreamingTextDecoderUserDefined): 20 * platform/text/mac/TextCodecMac.cpp: 21 (WebCore::newTextCodecMac): 22 * workers/Worker.cpp: 23 (WebCore::Worker::notifyFinished): 24 1 25 2011-04-26 Justin Novosad <junov@chromium.org> 2 26 -
trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp
r79985 r85020 563 563 case CSSPropertyWebkitSvgShadow: { 564 564 if (isInherit) 565 return svgstyle->setShadow( m_parentStyle->svgStyle()->shadow() ? new ShadowData(*m_parentStyle->svgStyle()->shadow()) : 0);565 return svgstyle->setShadow(adoptPtr(m_parentStyle->svgStyle()->shadow() ? new ShadowData(*m_parentStyle->svgStyle()->shadow()) : 0)); 566 566 if (isInitial || primitiveValue) // initial | none 567 return svgstyle->setShadow( 0);567 return svgstyle->setShadow(PassOwnPtr<ShadowData>()); 568 568 569 569 if (!value->isValueList()) … … 589 589 ASSERT(!item->style); 590 590 591 ShadowData* shadowData = new ShadowData(x, y, blur, 0, Normal, false, color.isValid() ? color : Color::transparent);592 svgstyle->setShadow(shadowData );591 OwnPtr<ShadowData> shadowData = adoptPtr(new ShadowData(x, y, blur, 0, Normal, false, color.isValid() ? color : Color::transparent)); 592 svgstyle->setShadow(shadowData.release()); 593 593 return; 594 594 } -
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
r84764 r85020 372 372 if (!context) { 373 373 canvas->dispatchEvent(WebGLContextEvent::create(eventNames().webglcontextcreationerrorEvent, false, true, "Could not create a WebGL context.")); 374 return 0;375 } 376 377 return new WebGLRenderingContext(canvas, context, attributes);374 return PassOwnPtr<WebGLRenderingContext>(); 375 } 376 377 return adoptPtr(new WebGLRenderingContext(canvas, context, attributes)); 378 378 } 379 379 … … 474 474 { 475 475 detachAndRemoveAllObjects(); 476 m_context->setContextLostCallback( 0);476 m_context->setContextLostCallback(PassOwnPtr<GraphicsContext3D::ContextLostCallback>()); 477 477 } 478 478 -
trunk/Source/WebCore/platform/text/TextCodecLatin1.cpp
r78580 r85020 105 105 static PassOwnPtr<TextCodec> newStreamingTextDecoderWindowsLatin1(const TextEncoding&, const void*) 106 106 { 107 return new TextCodecLatin1;107 return adoptPtr(new TextCodecLatin1); 108 108 } 109 109 -
trunk/Source/WebCore/platform/text/TextCodecUTF16.cpp
r79486 r85020 53 53 static PassOwnPtr<TextCodec> newStreamingTextDecoderUTF16LE(const TextEncoding&, const void*) 54 54 { 55 return new TextCodecUTF16(true);55 return adoptPtr(new TextCodecUTF16(true)); 56 56 } 57 57 58 58 static PassOwnPtr<TextCodec> newStreamingTextDecoderUTF16BE(const TextEncoding&, const void*) 59 59 { 60 return new TextCodecUTF16(false);60 return adoptPtr(new TextCodecUTF16(false)); 61 61 } 62 62 -
trunk/Source/WebCore/platform/text/TextCodecUserDefined.cpp
r65077 r85020 42 42 static PassOwnPtr<TextCodec> newStreamingTextDecoderUserDefined(const TextEncoding&, const void*) 43 43 { 44 return new TextCodecUserDefined;44 return adoptPtr(new TextCodecUserDefined); 45 45 } 46 46 -
trunk/Source/WebCore/platform/text/mac/TextCodecMac.cpp
r77062 r85020 68 68 static PassOwnPtr<TextCodec> newTextCodecMac(const TextEncoding&, const void* additionalData) 69 69 { 70 return new TextCodecMac(*static_cast<const TECTextEncodingID*>(additionalData));70 return adoptPtr(new TextCodecMac(*static_cast<const TECTextEncodingID*>(additionalData))); 71 71 } 72 72 -
trunk/Source/WebCore/workers/Worker.cpp
r84773 r85020 137 137 InspectorInstrumentation::scriptImported(scriptExecutionContext(), m_scriptLoader->identifier(), m_scriptLoader->script()); 138 138 } 139 m_scriptLoader = 0;139 m_scriptLoader = nullptr; 140 140 141 141 unsetPendingActivity(this);
Note: See TracChangeset
for help on using the changeset viewer.