Changeset 85028 in webkit

Timestamp:

Apr 27, 2011 12:15:48 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

OwnPtr assignment operator should be private
​https://bugs.webkit.org/show_bug.cgi?id=59487

Unfortunately we can't remove the copy constructor because of some
detail about gcc. (The issue is documented in a comment already.)

• wtf/OwnPtr.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/OwnPtr.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-04-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Kenneth Russell.
+
+        OwnPtr assignment operator should be private
+        https://bugs.webkit.org/show_bug.cgi?id=59487
+
+        Unfortunately we can't remove the copy constructor because of some
+        detail about gcc.  (The issue is documented in a comment already.)
+
+        * wtf/OwnPtr.h:
+
 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/JavaScriptCore/wtf/OwnPtr.h

@@ -84 +84 @@
 
     private:
+        OwnPtr& operator=(const OwnPtr<T>&);
+
         PtrType m_ptr;
     };