Changeset 85061 in webkit

Timestamp:

Apr 27, 2011 10:42:49 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84987.
​http://trac.webkit.org/changeset/84987
​https://bugs.webkit.org/show_bug.cgi?id=59618

Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).

• platform/gtk/Skipped:

2011-04-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84987.
​http://trac.webkit.org/changeset/84987
​https://bugs.webkit.org/show_bug.cgi?id=59618

Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r84987.
+        http://trac.webkit.org/changeset/84987
+        https://bugs.webkit.org/show_bug.cgi?id=59618
+
+        Caused crashes on the GTK+ debug bots. (Requested by mrobinson
+        on #webkit).
+
+        * platform/gtk/Skipped:
+
 2011-04-27  Levi Weintraub  <leviw@chromium.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -186 +186 @@
 # https://bugs.webkit.org/show_bug.cgi?id=56309
 svg/text/text-deco-01-b.svg
+
+# https://bugs.webkit.org/show_bug.cgi?id=58988
+storage/open-database-set-empty-version.html
 
 ###############################################################################

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-04-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r84987.
+        http://trac.webkit.org/changeset/84987
+        https://bugs.webkit.org/show_bug.cgi?id=59618
+
+        Caused crashes on the GTK+ debug bots. (Requested by mrobinson
+        on #webkit).
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        (WebKit::ChromeClient::exceededDatabaseQuota):
+
 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

@@ -587 +587 @@
 void ChromeClient::exceededDatabaseQuota(Frame* frame, const String& databaseName)
 {
-    DatabaseTracker::tracker().setQuota(frame->document()->securityOrigin(),
-                                        webkit_get_default_web_database_quota());
-
-    GRefPtr<WebKitSecurityOrigin> origin = adoptGRef(kit(frame->document()->securityOrigin()));
-    g_signal_emit_by_name(m_webView, "database-quota-exceeded", kit(frame),
-                          webkit_security_origin_get_web_database(origin.get(),
-                          databaseName.utf8().data()));
+    guint64 defaultQuota = webkit_get_default_web_database_quota();
+    DatabaseTracker::tracker().setQuota(frame->document()->securityOrigin(), defaultQuota);
+
+    WebKitWebFrame* webFrame = kit(frame);
+    WebKitSecurityOrigin* origin = webkit_web_frame_get_security_origin(webFrame);
+    WebKitWebDatabase* webDatabase = webkit_security_origin_get_web_database(origin, databaseName.utf8().data());
+    g_signal_emit_by_name(m_webView, "database-quota-exceeded", webFrame, webDatabase);
 }
 #endif