Changeset 85066 in webkit
- Timestamp:
- Apr 27, 2011 11:21:38 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 5 edited
-
LayoutTests/ChangeLog (modified) (1 diff)
-
LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum (added)
-
LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png (modified) (previous)
-
LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt (modified) (7 diffs)
-
Source/WebKit/gtk/ChangeLog (modified) (1 diff)
-
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (modified) (1 diff)
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r85064 r85066 1 2011-04-27 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Eric Seidel. 4 5 [GTK] Menulists do not follow text direction when rendering options with right-to-left text 6 https://bugs.webkit.org/show_bug.cgi?id=54038 7 8 * platform/gtk/Skipped: Unskip passing test. 9 * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added. 10 * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added. 11 * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added. 12 1 13 2011-02-03 Martin Robinson <mrobinson@igalia.com> 2 14 -
trunk/LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt
r82033 r85066 27 27 RenderBlock (anonymous) at (1,1) size 498x25 28 28 RenderText at (3,3) size 181x19 29 text run at (3,3) width 35: "First"30 text run at ( 38,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}"31 text run at ( 94,3) width 18: "03"32 text run at (1 12,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} ("33 text run at (15 5,3) width 29: " fifth"29 text run at (3,3) width 25: "fifth" 30 text run at (28,3) width 60 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} " 31 text run at (88,3) width 18: "03" 32 text run at (106,3) width 47 RTL: " \x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 33 text run at (153,3) width 31: "First" 34 34 RenderBlock {DIV} at (0,95) size 470x35 35 35 RenderText {#text} at (10,10) size 155x15 … … 42 42 RenderBlock (anonymous) at (1,1) size 498x25 43 43 RenderText at (3,3) size 181x19 44 text run at (3,3) width 35: "First " 45 text run at (38,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}" 46 text run at (94,3) width 18: "03" 47 text run at (112,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 48 text run at (155,3) width 29: " fifth" 44 text run at (3,3) width 181 LTR override: "First \x{5E9}\x{5E0}\x{5D9}\x{5D4} (03) \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} fifth" 49 45 RenderBlock {DIV} at (0,161) size 470x35 50 46 RenderText {#text} at (10,10) size 155x15 … … 53 49 RenderBlock (anonymous) at (1,1) size 498x25 54 50 RenderText at (3,3) size 181x19 55 text run at (3,3) width 35: "First " 56 text run at (38,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}" 57 text run at (94,3) width 18: "03" 58 text run at (112,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 59 text run at (155,3) width 29: " fifth" 51 text run at (3,3) width 181 RTL override: "First \x{5E9}\x{5E0}\x{5D9}\x{5D4} (03) \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} fifth" 60 52 RenderBlock {DIV} at (0,227) size 470x35 61 53 RenderText {#text} at (10,10) size 155x15 … … 64 56 RenderMenuList {SELECT} at (0,0) size 500x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 65 57 RenderBlock (anonymous) at (1,1) size 498x25 66 RenderText at ( 23,3) size 181x1967 text run at ( 23,3) width 35: "First "68 text run at ( 58,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}"69 text run at ( 114,3) width 18: "03"70 text run at ( 132,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} ("71 text run at ( 175,3) width 29: " fifth"58 RenderText at (314,3) size 181x19 59 text run at (314,3) width 35: "First " 60 text run at (349,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}" 61 text run at (405,3) width 18: "03" 62 text run at (423,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 63 text run at (466,3) width 29: " fifth" 72 64 RenderBlock {DIV} at (0,29) size 470x35 73 65 RenderText {#text} at (305,10) size 155x15 … … 79 71 RenderMenuList {SELECT} at (0,66) size 500x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 80 72 RenderBlock (anonymous) at (1,1) size 498x25 81 RenderText at ( 23,3) size 181x1982 text run at ( 23,3) width 35: "First"83 text run at ( 58,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}"84 text run at ( 114,3) width 18: "03"85 text run at ( 132,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} ("86 text run at ( 175,3) width 29: " fifth"73 RenderText at (314,3) size 181x19 74 text run at (314,3) width 25: "fifth" 75 text run at (339,3) width 60 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} " 76 text run at (399,3) width 18: "03" 77 text run at (417,3) width 47 RTL: " \x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 78 text run at (464,3) width 31: "First" 87 79 RenderBlock {DIV} at (0,95) size 470x35 88 80 RenderText {#text} at (305,10) size 155x15 … … 94 86 RenderMenuList {SELECT} at (0,132) size 500x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 95 87 RenderBlock (anonymous) at (1,1) size 498x25 96 RenderText at (23,3) size 181x19 97 text run at (23,3) width 35: "First " 98 text run at (58,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}" 99 text run at (114,3) width 18: "03" 100 text run at (132,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 101 text run at (175,3) width 29: " fifth" 88 RenderText at (314,3) size 181x19 89 text run at (314,3) width 181 LTR override: "First \x{5E9}\x{5E0}\x{5D9}\x{5D4} (03) \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} fifth" 102 90 RenderBlock {DIV} at (0,161) size 470x35 103 91 RenderText {#text} at (305,10) size 155x15 … … 105 93 RenderMenuList {SELECT} at (0,198) size 500x27 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 106 94 RenderBlock (anonymous) at (1,1) size 498x25 107 RenderText at (23,3) size 181x19 108 text run at (23,3) width 35: "First " 109 text run at (58,3) width 56 RTL: ") \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA}" 110 text run at (114,3) width 18: "03" 111 text run at (132,3) width 43 RTL: "\x{5E9}\x{5E0}\x{5D9}\x{5D4} (" 112 text run at (175,3) width 29: " fifth" 95 RenderText at (314,3) size 181x19 96 text run at (314,3) width 181 RTL override: "First \x{5E9}\x{5E0}\x{5D9}\x{5D4} (03) \x{5E8}\x{5D1}\x{5D9}\x{5E2}\x{5D9}\x{5EA} fifth" 113 97 RenderBlock {DIV} at (0,227) size 470x35 114 98 RenderText {#text} at (305,10) size 155x15 -
trunk/Source/WebKit/gtk/ChangeLog
r85061 r85066 1 2011-04-27 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by Eric Seidel. 4 5 [GTK] Menulists do not follow text direction when rendering options with right-to-left text 6 https://bugs.webkit.org/show_bug.cgi?id=54038 7 8 Fix rendering of menulists that contain right-to-left text. Text direction 9 inside a menulist now follows the alignment of its contents. 10 11 * WebCoreSupport/ChromeClientGtk.cpp: 12 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true. 13 (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false. 14 1 15 2011-04-27 Sheriff Bot <webkit.review.bot@gmail.com> 2 16 -
trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
r85061 r85066 687 687 bool ChromeClient::selectItemWritingDirectionIsNatural() 688 688 { 689 return false; 690 } 691 692 bool ChromeClient::selectItemAlignmentFollowsMenuWritingDirection() 693 { 689 694 return true; 690 }691 692 bool ChromeClient::selectItemAlignmentFollowsMenuWritingDirection()693 {694 return false;695 695 } 696 696
Note: See TracChangeset
for help on using the changeset viewer.
