Changeset 85095 in webkit
- Timestamp:
- Apr 27, 2011 2:27:06 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r85087 r85095 1 2011-04-22 Ojan Vafai <ojan@chromium.org> 2 3 Reviewed by Tony Chang. 4 5 only include failures in full_results.json 6 https://bugs.webkit.org/show_bug.cgi?id=59256 7 8 * Scripts/webkitpy/layout_tests/layout_package/manager.py: 9 1 10 2011-04-22 Ojan Vafai <ojan@chromium.org> 2 11 -
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py
r85087 r85095 72 72 73 73 def summarize_results(port_obj, expectations, result_summary, retry_summary, test_timings, only_unexpected): 74 """Summarize any unexpectedresults as a dict.74 """Summarize failing results as a dict. 75 75 76 76 FIXME: split this data structure into a separate class? … … 126 126 actual = [keywords[result_type]] 127 127 128 # FIXME: only include passing tests that have stderr output. 128 test_dict = {} 129 if False: 130 test_dict['has_stderr'] = True 131 129 132 if result_type == test_expectations.PASS: 130 133 num_passes += 1 134 # FIXME: include passing tests that have stderr output. 135 if expected == 'PASS': 136 continue 131 137 elif result_type == test_expectations.CRASH: 132 138 num_regressions += 1 … … 143 149 num_regressions += 1 144 150 145 tests[test] = {} 146 tests[test]['expected'] = expected 147 tests[test]['actual'] = " ".join(actual) 151 test_dict['expected'] = expected 152 test_dict['actual'] = " ".join(actual) 148 153 # FIXME: Set this correctly once https://webkit.org/b/37739 is fixed 149 154 # and only set it if there actually is stderr data. 150 if False:151 tests[test]['has_stderr'] = True152 155 153 156 failure_types = [type(f) for f in result.failures] 157 # FIXME: get rid of all this is_* values once there is a 1:1 map between 158 # TestFailure type and test_expectations.EXPECTATION. 154 159 if test_failures.FailureMissingAudio in failure_types: 155 test s[test]['is_missing_audio'] = True160 test_dict['is_missing_audio'] = True 156 161 157 162 if test_failures.FailureReftestMismatch in failure_types: 158 test s[test]['is_reftest'] = True163 test_dict['is_reftest'] = True 159 164 160 165 for f in result.failures: 161 166 if 'is_reftest' in result.failures: 162 test s[test]['is_reftest'] = True167 test_dict['is_reftest'] = True 163 168 164 169 if test_failures.FailureReftestMismatchDidNotOccur in failure_types: 165 test s[test]['is_mismatch_reftest'] = True170 test_dict['is_mismatch_reftest'] = True 166 171 167 172 if test_failures.FailureMissingResult in failure_types: 168 test s[test]['is_missing_text'] = True173 test_dict['is_missing_text'] = True 169 174 170 175 if test_failures.FailureMissingImage in failure_types or test_failures.FailureMissingImageHash in failure_types: 171 tests[test]['is_missing_image'] = True 176 test_dict['is_missing_image'] = True 177 178 tests[test] = test_dict 172 179 173 180 results['tests'] = tests
Note: See TracChangeset
for help on using the changeset viewer.