Changeset 85095 in webkit


Ignore:
Timestamp:
Apr 27, 2011 2:27:06 PM (13 years ago)
Author:
ojan@chromium.org
Message:

2011-04-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

only include failures in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=59256

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r85087 r85095  
     12011-04-22  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        only include failures in full_results.json
     6        https://bugs.webkit.org/show_bug.cgi?id=59256
     7
     8        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
     9
    1102011-04-22  Ojan Vafai  <ojan@chromium.org>
    211
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py

    r85087 r85095  
    7272
    7373def summarize_results(port_obj, expectations, result_summary, retry_summary, test_timings, only_unexpected):
    74     """Summarize any unexpected results as a dict.
     74    """Summarize failing results as a dict.
    7575
    7676    FIXME: split this data structure into a separate class?
     
    126126        actual = [keywords[result_type]]
    127127
    128         # FIXME: only include passing tests that have stderr output.
     128        test_dict = {}
     129        if False:
     130            test_dict['has_stderr'] = True
     131
    129132        if result_type == test_expectations.PASS:
    130133            num_passes += 1
     134            # FIXME: include passing tests that have stderr output.
     135            if expected == 'PASS':
     136                continue
    131137        elif result_type == test_expectations.CRASH:
    132138            num_regressions += 1
     
    143149                    num_regressions += 1
    144150
    145         tests[test] = {}
    146         tests[test]['expected'] = expected
    147         tests[test]['actual'] = " ".join(actual)
     151        test_dict['expected'] = expected
     152        test_dict['actual'] = " ".join(actual)
    148153        # FIXME: Set this correctly once https://webkit.org/b/37739 is fixed
    149154        # and only set it if there actually is stderr data.
    150         if False:
    151             tests[test]['has_stderr'] = True
    152155
    153156        failure_types = [type(f) for f in result.failures]
     157        # FIXME: get rid of all this is_* values once there is a 1:1 map between
     158        # TestFailure type and test_expectations.EXPECTATION.
    154159        if test_failures.FailureMissingAudio in failure_types:
    155             tests[test]['is_missing_audio'] = True
     160            test_dict['is_missing_audio'] = True
    156161
    157162        if test_failures.FailureReftestMismatch in failure_types:
    158             tests[test]['is_reftest'] = True
     163            test_dict['is_reftest'] = True
    159164
    160165        for f in result.failures:
    161166            if 'is_reftest' in result.failures:
    162                 tests[test]['is_reftest'] = True
     167                test_dict['is_reftest'] = True
    163168
    164169        if test_failures.FailureReftestMismatchDidNotOccur in failure_types:
    165             tests[test]['is_mismatch_reftest'] = True
     170            test_dict['is_mismatch_reftest'] = True
    166171
    167172        if test_failures.FailureMissingResult in failure_types:
    168             tests[test]['is_missing_text'] = True
     173            test_dict['is_missing_text'] = True
    169174
    170175        if test_failures.FailureMissingImage in failure_types or test_failures.FailureMissingImageHash in failure_types:
    171             tests[test]['is_missing_image'] = True
     176            test_dict['is_missing_image'] = True
     177
     178        tests[test] = test_dict
    172179
    173180    results['tests'] = tests
Note: See TracChangeset for help on using the changeset viewer.