Changeset 85145 in webkit


Ignore:
Timestamp:
Apr 27, 2011 9:11:58 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-27 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB object store deleting entry should fail if key is null
​https://bugs.webkit.org/show_bug.cgi?id=58614

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html: Added.

2011-04-27 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB object store delete should fail if key is null
​https://bugs.webkit.org/show_bug.cgi?id=58614

Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r85144 r85145  
     12011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB object store deleting entry should fail if key is null
     6        https://bugs.webkit.org/show_bug.cgi?id=58614
     7
     8        * storage/indexeddb/mozilla: Added.
     9        * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt: Added.
     10        * storage/indexeddb/mozilla/key-requirements-delete-null-key.html: Added.
     11
    1122011-04-27  Eric Carlson  <eric.carlson@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r85143 r85145  
     12011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Reviewed by Tony Chang.
     4
     5        IndexedDB object store delete should fail if key is null
     6        https://bugs.webkit.org/show_bug.cgi?id=58614
     7
     8        Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
     9
     10        * storage/IDBObjectStoreBackendImpl.cpp:
     11        (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
     12
    1132011-04-27  Eric Seidel  <eric@webkit.org>
    214

  • trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp

    r83443 r85145  
    280280    RefPtr<IDBKey> key = prpKey;
    281281    RefPtr<IDBCallbacks> callbacks = prpCallbacks;
     282    if (key->type() == IDBKey::NullType) {
     283        ec = IDBDatabaseException::DATA_ERR;
     284        return;
     285    }
    282286
    283287    if (!transaction->scheduleTask(createCallbackTask(&IDBObjectStoreBackendImpl::deleteInternal, objectStore, key, callbacks)))
Note: See TracChangeset for help on using the changeset viewer.