Changeset 85176 in webkit

Timestamp:

Apr 28, 2011 4:14:30 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-04-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

PluginStream should play nice with strict OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59675

These failures appear when enabling strict OwnPtr on Qt.

• plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): (WebCore::PluginStream::didReceiveData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginStream.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-28  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        PluginStream should play nice with strict OwnPtr
+        https://bugs.webkit.org/show_bug.cgi?id=59675
+
+        These failures appear when enabling strict OwnPtr on Qt.
+
+        * plugins/PluginStream.cpp:
+        (WebCore::PluginStream::PluginStream):
+        (WebCore::PluginStream::didReceiveData):
+
 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/plugins/PluginStream.cpp

@@ -64 +64 @@
     , m_loadManually(false)
     , m_delayDeliveryTimer(this, &PluginStream::delayDeliveryTimerFired)
-    , m_deliveryData(0)
     , m_tempFileHandle(invalidPlatformFileHandle)
     , m_pluginFuncs(pluginFuncs)
@@ -416 +415 @@
     if (m_transferMode != NP_ASFILEONLY) {
         if (!m_deliveryData)
-            m_deliveryData.set(new Vector<char>);
+            m_deliveryData = adoptPtr(new Vector<char>);
 
         int oldSize = m_deliveryData->size();