Changeset 85191 in webkit

Timestamp:

Apr 28, 2011 9:18:49 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-04-28 Satish Sampath <​satish@chromium.org>

Reviewed by Tony Gentilcore.

Speech input button layout issues with padding and border.
​https://bugs.webkit.org/show_bug.cgi?id=59613

• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• inspector/front-end/Images/prettyPrintButtonGlyph.png (added)
• inspector/front-end/ScriptsPanel.js (modified) (3 diffs)
• inspector/front-end/WebKit.qrc (modified) (1 diff)
• inspector/front-end/inspector.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ -27 +27 @@
         * platform/gtk/ScrollViewGtk.cpp:
         (WebCore::ScrollView::createScrollbar):
+
+2011-04-28  Pavel Feldman  <pfeldman@google.com>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: add status bar button for pretty print.
+        https://bugs.webkit.org/show_bug.cgi?id=59467
+
+        * WebCore.gypi:
+        * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        (WebInspector.ScriptsPanel.prototype.get statusBarItems):
+        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.css:
+        (.scripts-toggle-pretty-print-status-bar-item .glyph):
+        (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
 
 2011-04-28  Pavel Feldman  <pfeldman@google.com>

trunk/Source/WebCore/WebCore.gypi

@@ -6362 +6362 @@
             'inspector/front-end/Images/popoverArrows.png',
             'inspector/front-end/Images/popoverBackground.png',
+            'inspector/front-end/Images/prettyPrintButtonGlyph.png',
             'inspector/front-end/Images/profileGroupIcon.png',
             'inspector/front-end/Images/profileIcon.png',

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -172 +172 @@
     this._pauseOnExceptionButton.addEventListener("click", this._togglePauseOnExceptions.bind(this), false);
 
+    this._toggleFormatSourceFilesButton = new WebInspector.StatusBarButton(WebInspector.UIString("Pretty print"), "scripts-toggle-pretty-print-status-bar-item");
+    this._toggleFormatSourceFilesButton.toggled = false;
+    this._toggleFormatSourceFilesButton.addEventListener("click", this._toggleFormatSourceFiles.bind(this), false);
+
     this._registerShortcuts();
 
@@ -216 +220 @@
     get statusBarItems()
     {
-        return [this.enableToggleButton.element, this._pauseOnExceptionButton.element];
+        return [this.enableToggleButton.element, this._pauseOnExceptionButton.element, this._toggleFormatSourceFilesButton.element];
     },
 
@@ -1007 +1011 @@
             this._searchView.jumpToPreviousSearchResult();
     },
+
+    _toggleFormatSourceFiles: function()
+    {
+        WebInspector.panels.scripts.reset();
+        this._presentationModel.toggleFormatSourceFiles();
+        this._toggleFormatSourceFilesButton.toggled = this._presentationModel.formatSourceFilesToggled();
+    }
 }
 

trunk/Source/WebCore/inspector/front-end/WebKit.qrc

@@ -202 +202 @@
     <file>Images/popoverArrows.png</file>
     <file>Images/popoverBackground.png</file>
+    <file>Images/prettyPrintButtonGlyph.png</file>
     <file>Images/profileGroupIcon.png</file>
     <file>Images/profileIcon.png</file>

trunk/Source/WebCore/inspector/front-end/inspector.css

@@ -2558 +2558 @@
 }
 
+.scripts-toggle-pretty-print-status-bar-item .glyph {
+    -webkit-mask-image: url(Images/prettyPrintButtonGlyph.png);
+}
+
+.scripts-toggle-pretty-print-status-bar-item.toggled .glyph {
+    background-color: rgb(66, 129, 235);
+}
+
 #scripts-status-bar {
     position: absolute;