Changeset 85204 in webkit

Timestamp:

Apr 28, 2011 10:20:47 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

2011-04-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "Pretty print" source frame context menu item.
​https://bugs.webkit.org/show_bug.cgi?id=59709

• inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
• inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DebuggerPresentationModel.js (modified) (2 diffs)
• inspector/front-end/ScriptsPanel.js (modified) (2 diffs)
• inspector/front-end/SourceFrame.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: remove "Pretty print" source frame context menu item.
+        https://bugs.webkit.org/show_bug.cgi?id=59709
+
+        * inspector/front-end/DebuggerPresentationModel.js:
+        (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
+
 2011-04-28  Satish Sampath  <satish@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

@@ -198 +198 @@
     },
 
-    toggleFormatSourceFiles: function()
-    {
-        this._formatSourceFiles = !this._formatSourceFiles;
+    setFormatSourceFiles: function(formatSourceFiles)
+    {
+        if (this._formatSourceFiles === formatSourceFiles)
+            return;
+
+        this._formatSourceFiles = formatSourceFiles;
 
         for (var id in this._sourceFiles) {
@@ -220 +223 @@
         if (WebInspector.debuggerModel.callFrames)
             this._debuggerPaused();
-    },
-
-    formatSourceFilesToggled: function()
-    {
-        return this._formatSourceFiles;
     },
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -1015 +1015 @@
     {
         WebInspector.panels.scripts.reset();
-        this._presentationModel.toggleFormatSourceFiles();
-        this._toggleFormatSourceFilesButton.toggled = this._presentationModel.formatSourceFilesToggled();
+        this._toggleFormatSourceFilesButton.toggled = !this._toggleFormatSourceFilesButton.toggled;
+        this._presentationModel.setFormatSourceFiles(this._toggleFormatSourceFilesButton.toggled);
     }
 }
@@ -1101 +1101 @@
     },
 
-    toggleFormatSourceFiles: function()
-    {
-        WebInspector.panels.scripts.reset();
-        this._model.toggleFormatSourceFiles();
-    },
-
-    formatSourceFilesToggled: function()
-    {
-        return this._model.formatSourceFilesToggled();
-    },
-
     suggestedFileName: function()
     {

trunk/Source/WebCore/inspector/front-end/SourceFrame.js

@@ -652 +652 @@
     populateTextAreaContextMenu: function(contextMenu)
     {
-        if (this._delegate.debuggingSupported())
-            contextMenu.appendCheckboxItem(WebInspector.UIString("Pretty print"), this._delegate.toggleFormatSourceFiles.bind(this._delegate), this._delegate.formatSourceFilesToggled());
     },
 
@@ -1013 +1011 @@
     },
 
-    toggleFormatSourceFiles: function()
-    {
-        // Should be implemented by subclasses.
-    },
-
-    formatSourceFilesToggled: function()
-    {
-        // Should be implemented by subclasses.
-    },
-
     suggestedFileName: function()
     {