Changeset 85255 in webkit


Ignore:
Timestamp:
Apr 28, 2011 4:14:13 PM (13 years ago)
Author:
ojan@chromium.org
Message:

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

use a hierarchical data structure to store results json
https://bugs.webkit.org/show_bug.cgi?id=59736

Instead of a map from test name to results dict, we now store a hierarchical
data structure.

Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
New:
{ foo: {

bar: {

baz.html: results_dict,
baz2.html: results_dict } } }

This cut ~52% of the size of times_ms.json. I expect it will cut
30-40% of full_results.json and unexpected_results.json.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Using os.sep was just wrong since relative_test_filename canonicalizes separators.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py: Instead of plumbing through the change to all of the rebaselineserver python and JS, just convert to the old format after reading in the json.
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r85254 r85255  
    2929        Instead of plumbing through the change to all of the rebaselineserver
    3030        python and JS, just convert to the old format after reading in the json.
     31
     322011-04-28  Eric Seidel  <eric@webkit.org>
     33
     34        Reviewed by Adam Barth.
     35
     36        EWS Bubbles should show commit-queue position when patch is in the commit-queue
     37        https://bugs.webkit.org/show_bug.cgi?id=59744
     38
     39        Add target="_top" to the bubble links.  This was
     40        forgotten when I moved from using an onclick to a normal link.
     41
     42        * QueueStatusServer/templates/statusbubble.html:
    3143
    32442011-04-28  Eric Seidel  <eric@webkit.org>
  • trunk/Tools/QueueStatusServer/templates/statusbubble.html

    r85251 r85255  
    7676{% else %}
    7777  {% for bubble in bubbles %}
    78   <a class="status {{ bubble.state }}"
     78  <a class="status {{ bubble.state }}" target="_top"
    7979  {% if bubble.status %}
    8080      href="http://queues.webkit.org/patch/{{ bubble.attachment_id }}"
Note: See TracChangeset for help on using the changeset viewer.