Changeset 85302 in webkit


Ignore:
Timestamp:
Apr 28, 2011 9:57:32 PM (13 years ago)
Author:
ddkilzer@apple.com
Message:

<​http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods

Reviewed by Anders Carlsson.

  • History/WebHistory.mm:

(-[WebHistoryPrivate init]):

  • Misc/WebElementDictionary.mm:

(-[WebElementDictionary initWithHitTestResult:]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):

  • Plugins/WebPluginController.mm:

(-[WebPluginController initWithDocumentView:]):

  • Plugins/WebPluginRequest.m:

(-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):

  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditCommand initWithEditCommand:]):

  • WebCoreSupport/WebJavaScriptTextInputPanel.m:

(-[WebJavaScriptTextInputPanel initWithPrompt:text:]):

  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

Location:
trunk/Source/WebKit/mac
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/mac/ChangeLog

    r85273 r85302  
     12011-04-28  David Kilzer  <ddkilzer@apple.com>
     2
     3        <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
     4
     5        Reviewed by Anders Carlsson.
     6
     7        * History/WebHistory.mm:
     8        (-[WebHistoryPrivate init]):
     9        * Misc/WebElementDictionary.mm:
     10        (-[WebElementDictionary initWithHitTestResult:]):
     11        * Misc/WebIconDatabase.mm:
     12        (-[WebIconDatabase init]):
     13        * Plugins/WebPluginController.mm:
     14        (-[WebPluginController initWithDocumentView:]):
     15        * Plugins/WebPluginRequest.m:
     16        (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
     17        * WebCoreSupport/WebEditorClient.mm:
     18        (-[WebEditCommand initWithEditCommand:]):
     19        * WebCoreSupport/WebJavaScriptTextInputPanel.m:
     20        (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
     21        * WebView/WebNavigationData.mm:
     22        (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
     23
    1242011-04-28  David Levin  <levin@chromium.org>
    225

  • trunk/Source/WebKit/mac/History/WebHistory.mm

    r74733 r85302  
    124124- (id)init
    125125{
    126     if (![super init])
     126    self = [super init];
     127    if (!self)
    127128        return nil;
    128129   

  • trunk/Source/WebKit/mac/Misc/WebElementDictionary.mm

    r85036 r85302  
    9999{
    100100    [[self class] initializeLookupTable];
    101     [super init];
     101    self = [super init];
     102    if (!self)
     103        return nil;
    102104    _result = new HitTestResult(result);
    103105    return self;

  • trunk/Source/WebKit/mac/Misc/WebIconDatabase.mm

    r83324 r85302  
    107107- (id)init
    108108{
    109     [super init];
     109    self = [super init];
     110    if (!self)
     111        return nil;
    110112    WebCoreThreadViolationCheckRoundOne();
    111113       

  • trunk/Source/WebKit/mac/Plugins/WebPluginController.mm

    r73149 r85302  
    123123- (id)initWithDocumentView:(NSView *)view
    124124{
    125     [super init];
     125    self = [super init];
     126    if (!self)
     127        return nil;
    126128    _documentView = view;
    127129    _views = [[NSMutableArray alloc] init];

  • trunk/Source/WebKit/mac/Plugins/WebPluginRequest.m

    r38981 r85302  
    3535- (id)initWithRequest:(NSURLRequest *)request frameName:(NSString *)frameName notifyData:(void *)notifyData sendNotification:(BOOL)sendNotification didStartFromUserGesture:(BOOL)currentEventIsUserGesture
    3636{
    37     [super init];
     37    self = [super init];
     38    if (!self)
     39        return nil;
    3840    _didStartFromUserGesture = currentEventIsUserGesture;
    3941    _request = [request retain];

  • trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

    r85036 r85302  
    116116{
    117117    ASSERT(command);
    118     [super init];
     118    self = [super init];
     119    if (!self)
     120        return nil;
    119121    m_command = command;
    120122    return self;

  • trunk/Source/WebKit/mac/WebCoreSupport/WebJavaScriptTextInputPanel.m

    r34956 r85302  
    3838- (id)initWithPrompt:(NSString *)p text:(NSString *)t
    3939{
    40     [self initWithWindowNibName:@"WebJavaScriptTextInputPanel"];
     40    self = [self initWithWindowNibName:@"WebJavaScriptTextInputPanel"];
     41    if (!self)
     42        return nil;
    4143    NSWindow *window = [self window];
    4244   

  • trunk/Source/WebKit/mac/WebView/WebNavigationData.mm

    r61562 r85302  
    5858- (id)initWithURLString:(NSString *)url title:(NSString *)title originalRequest:(NSURLRequest *)request response:(NSURLResponse *)response hasSubstituteData:(BOOL)hasSubstituteData clientRedirectSource:(NSString *)redirectSource
    5959{
     60    self = [super init];
     61    if (!self)
     62        return nil;
    6063    _private = [[WebNavigationDataPrivate alloc] init];
    6164   
Note: See TracChangeset for help on using the changeset viewer.