Changeset 85307 in webkit

Timestamp:

Apr 28, 2011 11:53:23 PM (13 years ago)

Author:

Adam Roben

Message:

Stop and restart ATSServer before each test run on Leopard

This is to work around an ATSServer leak that eventually causes tests
to fail.

Fixes <​http://webkit.org/b/51807> <rdar://problem/9273894>
fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
(due to ATSServer leak)

Reviewed by Dan Bernstein.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(StopATSServer):
(StartATSServer):
Added these new commands to stop and start ATSServer.

(TestFactory.init): Stop and start ATSServer on Leopard before running tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -433 +433 @@
 
 
+class StopATSServer(shell.ShellCommand):
+    command = ["launchctl", "stop", "com.apple.ATSServer"]
+    name = "stop-ats-server"
+    description = ["stopping ATSServer"]
+    descriptionDone = ["stopped ATSServer"]
+
+
+class StartATSServer(shell.ShellCommand):
+    command = ["launchctl", "start", "com.apple.ATSServer"]
+    name = "start-ats-server"
+    description = ["starting ATSServer"]
+    descriptionDone = ["started ATSServer"]
+
+
 class Factory(factory.BuildFactory):
     def __init__(self, platform, configuration, architectures, buildOnly):
@@ -459 +473 @@
     def __init__(self, platform, configuration, architectures):
         Factory.__init__(self, platform, configuration, architectures, False)
+        if platform == "mac-leopard":
+            # Work around an ATSServer leak. See <http://webkit.org/b/51807>.
+            self.addStep(StopATSServer)
+            self.addStep(StartATSServer)
         self.addStep(DownloadBuiltProduct)
         self.addStep(ExtractBuiltProduct)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-28  Adam Roben  <aroben@apple.com>
+
+        Stop and restart ATSServer before each test run on Leopard
+
+        This is to work around an ATSServer leak that eventually causes tests
+        to fail.
+
+        Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
+        fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
+        (due to ATSServer leak)
+
+        Reviewed by Dan Bernstein.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+        (StopATSServer):
+        (StartATSServer):
+        Added these new commands to stop and start ATSServer.
+
+        (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
+
 2011-04-28  Dirk Pranke  <dpranke@chromium.org>