Changeset 85350 in webkit


Ignore:
Timestamp:
Apr 29, 2011 12:32:35 PM (13 years ago)
Author:
jamesr@google.com
Message:

2011-04-29 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r85330.
http://trac.webkit.org/changeset/85330
https://bugs.webkit.org/show_bug.cgi?id=41311

Caused unexpected border rendering change on 500 tests on chromium linux.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r85349 r85350  
     12011-04-29  James Robinson  <jamesr@chromium.org>
     2
     3        Unreviewed, rolling out r85330.
     4        http://trac.webkit.org/changeset/85330
     5        https://bugs.webkit.org/show_bug.cgi?id=41311
     6
     7        Caused unexpected border rendering change on 500 tests on chromium linux.
     8
     9        * platform/graphics/skia/GraphicsContextSkia.cpp:
     10        (WebCore::GraphicsContext::drawConvexPolygon):
     11        (WebCore::GraphicsContext::clipConvexPolygon):
     12
    1132011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
    214
  • trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

    r85330 r85350  
    450450}
    451451
    452 static void setPathFromConvexPoints(SkPath* path, size_t numPoints, const FloatPoint* points)
    453 {
    454     path->incReserve(numPoints);
    455     path->moveTo(WebCoreFloatToSkScalar(points[0].x()),
    456                  WebCoreFloatToSkScalar(points[0].y()));
    457     for (size_t i = 1; i < numPoints; ++i) {
    458         path->lineTo(WebCoreFloatToSkScalar(points[i].x()),
    459                      WebCoreFloatToSkScalar(points[i].y()));
    460     }
    461     path->setIsConvex(true);
    462 }
    463 
    464452void GraphicsContext::drawConvexPolygon(size_t numPoints,
    465453                                        const FloatPoint* points,
     
    475463
    476464    SkPath path;
    477     setPathFromConvexPoints(&path, numPoints, points);
     465
     466    path.incReserve(numPoints);
     467    path.moveTo(WebCoreFloatToSkScalar(points[0].x()),
     468                WebCoreFloatToSkScalar(points[0].y()));
     469    for (size_t i = 1; i < numPoints; i++) {
     470        path.lineTo(WebCoreFloatToSkScalar(points[i].x()),
     471                    WebCoreFloatToSkScalar(points[i].y()));
     472    }
    478473
    479474    if (!isPathSkiaSafe(getCTM(), path))
     
    482477    SkPaint paint;
    483478    platformContext()->setupPaintForFilling(&paint);
    484     paint.setAntiAlias(shouldAntialias);
    485479    platformContext()->canvas()->drawPath(path, paint);
    486480
     
    500494        return;
    501495
    502     SkPath path;
    503     setPathFromConvexPoints(&path, numPoints, points);
    504     platformContext()->canvas()->clipPath(path);
     496    // FIXME: IMPLEMENT!!
    505497}
    506498
Note: See TracChangeset for help on using the changeset viewer.