Changeset 85414 in webkit

Timestamp:

May 1, 2011 9:07:19 AM (13 years ago)

Author:

Chris Fleizach

Message:

2011-05-01 Chris Fleizach <Chris Fleizach>

Reviewed by Maciej Stachowiak.

Crash in AccessibilityRenderObject while viewing PDFs in iframes
​https://bugs.webkit.org/show_bug.cgi?id=59629

Could not reproduce this crash, but it's quite clear how it could happen.

• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityHitTest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-01  Chris Fleizach  <cfleizach@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        Crash in AccessibilityRenderObject while viewing PDFs in iframes
+        https://bugs.webkit.org/show_bug.cgi?id=59629
+
+        Could not reproduce this crash, but it's quite clear how it could happen.
+ 
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::accessibilityHitTest):
+
 2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -2784 +2784 @@
     result = result->elementAccessibilityHitTest(point);
     
-    if (result->accessibilityIsIgnored()) {
+    if (result && result->accessibilityIsIgnored()) {
         // If this element is the label of a control, a hit test should return the control.
         AccessibilityObject* controlObject = result->correspondingControlForLabelElement();