Changeset 85460 in webkit

Timestamp:

May 1, 2011 11:18:46 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

expectedfailures.py should report the unexpected failures when asked
​https://bugs.webkit.org/show_bug.cgi?id=59916

This information is useful when the EWS runs tests.

• Scripts/webkitpy/tool/bot/expectedfailures.py:
• Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/expectedfailures.py (modified) (1 diff)
• Scripts/webkitpy/tool/bot/expectedfailures_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-01  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        expectedfailures.py should report the unexpected failures when asked
+        https://bugs.webkit.org/show_bug.cgi?id=59916
+
+        This information is useful when the EWS runs tests.
+
+        * Scripts/webkitpy/tool/bot/expectedfailures.py:
+        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
+
 2011-05-01  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/bot/expectedfailures.py

@@ -42 +42 @@
         return set(results.failing_tests()) <= self._failures
 
+    def unexpected_failures(self, results):
+        if not self._can_trust_results(results):
+            return None
+        return set(results.failing_tests()) - self._failures
+
     def shrink_expected_failures(self, results, run_success):
         if run_success:

trunk/Tools/Scripts/webkitpy/tool/bot/expectedfailures_unittest.py

@@ -72 +72 @@
         failures.shrink_expected_failures(MockResults(), True)
         self._assert_expected(failures, ['baz.html'], False)
+
+    def test_unexpected_failures(self):
+        failures = ExpectedFailures()
+        failures.grow_expected_failures(MockResults(['foo.html']))
+        self.assertEquals(failures.unexpected_failures(MockResults(['foo.html', 'bar.html'])), set(['bar.html']))
+        self.assertEquals(failures.unexpected_failures(MockResults(['baz.html'])), set(['baz.html']))