Changeset 85464 in webkit


Ignore:
Timestamp:
May 2, 2011 12:56:44 AM (13 years ago)
Author:
abarth@webkit.org
Message:

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch --non-interactive is incompatible with new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59919

new-run-webkit-tests doesn't support --wait-for-httpd (because it
always waits for HTTPD, as I understand things). It turns out we're
not really using this flag for anything, so we should just remove it.

  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r85463 r85464  
     12011-05-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        webkit-patch --non-interactive is incompatible with new-run-webkit-tests
     6        https://bugs.webkit.org/show_bug.cgi?id=59919
     7
     8        new-run-webkit-tests doesn't support --wait-for-httpd (because it
     9        always waits for HTTPD, as I understand things).  It turns out we're
     10        not really using this flag for anything, so we should just remove it.
     11
     12        * Scripts/webkitpy/tool/steps/runtests.py:
     13        * Scripts/webkitpy/tool/steps/steps_unittest.py:
     14
    1152011-05-01  Eric Seidel  <eric@webkit.org>
    216
  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py

    r83797 r85464  
    6464            args.append("--no-launch-safari")
    6565            args.append("--exit-after-n-failures=%s" % self.NON_INTERACTIVE_FAILURE_LIMIT_COUNT)
    66             args.append("--wait-for-httpd")
    6766
    6867        if self._options.quiet:
  • trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

    r83797 r85464  
    8383MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests']
    8484Running run-webkit-tests
    85 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=10', '--wait-for-httpd', '--quiet']
     85MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=10', '--quiet']
    8686"""
    8787        OutputCapture().assert_outputs(self, step.run, [{}], expected_stderr=expected_stderr)
Note: See TracChangeset for help on using the changeset viewer.