Changeset 85509 in webkit
- Timestamp:
- May 2, 2011 1:02:52 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r85504 r85509 1 2011-05-02 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 EWS should report the list of unexpected failures 6 https://bugs.webkit.org/show_bug.cgi?id=59923 7 8 We cache the results of the first layout test results run on the task 9 so the EWS can grab them later. Another option is to include them in 10 the exception that's thrown, but this approach seemed slightly more 11 aesthetic. 12 13 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 14 * Scripts/webkitpy/tool/bot/patchanalysistask.py: 15 1 16 2011-05-02 Adam Barth <abarth@webkit.org> 2 17 -
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
r85463 r85509 115 115 if not expected_exception: 116 116 self.assertEqual(success, not expect_retry) 117 return task 117 118 118 119 def test_success_case(self): … … 443 444 command_failed: failure_message='Unable to pass tests without patch (tree is red?)' script_error='MOCK clean test failure' patch='197' 444 445 """ 445 self._run_through_task(commit_queue, expected_stderr, ScriptError) 446 task = self._run_through_task(commit_queue, expected_stderr, ScriptError) 447 self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"]) 446 448 447 449 def test_land_failure(self): -
trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py
r85463 r85509 67 67 self._script_error = None 68 68 self._results_archive_from_patch_test_run = None 69 self._results_from_patch_test_run = None 69 70 self._expected_failures = delegate.expected_failures() 70 71 assert(self._expected_failures) … … 209 210 if self._build_and_test_without_patch(): 210 211 # The error from the previous ._test() run is real, report it. 211 return self.report_failure(first_results_archive )212 return self.report_failure(first_results_archive, first_results) 212 213 213 214 clean_tree_results = self._delegate.layout_test_results() … … 221 222 # tell if our original failures were unexpected and fail the patch if necessary. 222 223 if self._expected_failures.unexpected_failures(first_results): 223 return self.report_failure(first_results_archive )224 return self.report_failure(first_results_archive, first_results) 224 225 225 226 # We don't know what's going on. The tree is likely very red (beyond our layout-test-results … … 231 232 return self._results_archive_from_patch_test_run 232 233 233 def report_failure(self, results_archive=None): 234 def results_from_patch_test_run(self, patch): 235 assert(self._patch.id() == patch.id()) # PatchAnalysisTask is not currently re-useable. 236 return self._results_from_patch_test_run 237 238 def report_failure(self, results_archive=None, results=None): 234 239 if not self.validate(): 235 240 return False 236 241 self._results_archive_from_patch_test_run = results_archive 242 self._results_from_patch_test_run = results 237 243 raise self._script_error 238 244
Note: See TracChangeset
for help on using the changeset viewer.