Changeset 85597 in webkit


Ignore:
Timestamp:
May 3, 2011 5:56:07 AM (13 years ago)
Author:
pfeldman@chromium.org
Message:

2011-05-03 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger agent to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60019

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  • inspector/generate-inspector-idl:
Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r85596 r85597  
     12011-05-03  Pavel Feldman  <pfeldman@google.com>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: rename BrowserDebugger agent to DOMDebugger.
     6        https://bugs.webkit.org/show_bug.cgi?id=60019
     7
     8        * inspector/CodeGeneratorInspector.pm:
     9        * inspector/Inspector.json:
     10        * inspector/InspectorController.cpp:
     11        (WebCore::InspectorController::connectFrontend):
     12        * inspector/front-end/BreakpointsSidebarPane.js:
     13        (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
     14        (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
     15        (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
     16        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
     17        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
     18        * inspector/generate-inspector-idl:
     19
    1202011-05-03  Yury Semikhatsky  <yurys@chromium.org>
    221
  • trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

    r85319 r85597  
    3636    "domainAccessor" => "m_debuggerAgent",
    3737};
    38 $typeTransform{"BrowserDebugger"} = {
     38$typeTransform{"DOMDebugger"} = {
    3939    "forward" => "InspectorBrowserDebuggerAgent",
    4040    "header" => "InspectorBrowserDebuggerAgent.h",
  • trunk/Source/WebCore/inspector/Inspector.json

    r85320 r85597  
    15221522    },
    15231523    {
    1524         "domain": "BrowserDebugger",
    1525         "description": "Browser debugging allows setting breakpoints on particular DOM operations and events. JavaScript execution will stop on these operations as if there was a regular breakpoint set.",
     1524        "domain": "DOMDebugger",
     1525        "description": "DOM debugging allows setting breakpoints on particular DOM operations and events. JavaScript execution will stop on these operations as if there was a regular breakpoint set.",
    15261526        "commands": [
    15271527            {
  • trunk/Source/WebCore/inspector/InspectorController.cpp

    r85094 r85597  
    120120        m_inspectorAgent->applicationCacheAgent(),
    121121#endif
    122 #if ENABLE(JAVASCRIPT_DEBUGGER)
    123         m_inspectorAgent->browserDebuggerAgent(),
    124 #endif
    125122        m_inspectorAgent->cssAgent(),
    126123        m_inspectorAgent->consoleAgent(),
    127124        m_inspectorAgent->domAgent(),
     125#if ENABLE(JAVASCRIPT_DEBUGGER)
     126        m_inspectorAgent->browserDebuggerAgent(),
     127#endif
    128128#if ENABLE(DOM_STORAGE)
    129129        m_inspectorAgent->domStorageAgent(),
  • trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js

    r84622 r85597  
    322322        this._breakpointElements[url] = element;
    323323        if (enabled)
    324             BrowserDebuggerAgent.setXHRBreakpoint(url);
     324            DOMDebuggerAgent.setXHRBreakpoint(url);
    325325    },
    326326
     
    334334        delete this._breakpointElements[url];
    335335        if (element._checkboxElement.checked)
    336             BrowserDebuggerAgent.removeXHRBreakpoint(url);
     336            DOMDebuggerAgent.removeXHRBreakpoint(url);
    337337    },
    338338
     
    352352    {
    353353        if (event.target.checked)
    354             BrowserDebuggerAgent.setXHRBreakpoint(url);
     354            DOMDebuggerAgent.setXHRBreakpoint(url);
    355355        else
    356             BrowserDebuggerAgent.removeXHRBreakpoint(url);
     356            DOMDebuggerAgent.removeXHRBreakpoint(url);
    357357        this._saveBreakpoints();
    358358    },
     
    536536            return;
    537537        breakpointItem.checkbox.checked = true;
    538         BrowserDebuggerAgent.setEventListenerBreakpoint(eventName);
     538        DOMDebuggerAgent.setEventListenerBreakpoint(eventName);
    539539        this._updateCategoryCheckbox(breakpointItem.parent);
    540540    },
     
    546546            return;
    547547        breakpointItem.checkbox.checked = false;
    548         BrowserDebuggerAgent.removeEventListenerBreakpoint(eventName);
     548        DOMDebuggerAgent.removeEventListenerBreakpoint(eventName);
    549549        this._updateCategoryCheckbox(breakpointItem.parent);
    550550    },
  • trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js

    r85312 r85597  
    201201        this._breakpointElements[breakpointId] = element;
    202202        if (enabled)
    203             BrowserDebuggerAgent.setDOMBreakpoint(node.id, type);
     203            DOMDebuggerAgent.setDOMBreakpoint(node.id, type);
    204204    },
    205205
     
    214214        delete this._breakpointElements[breakpointId];
    215215        if (element._checkboxElement.checked)
    216             BrowserDebuggerAgent.removeDOMBreakpoint(node.id, type);
     216            DOMDebuggerAgent.removeDOMBreakpoint(node.id, type);
    217217    },
    218218
     
    232232    {
    233233        if (event.target.checked)
    234             BrowserDebuggerAgent.setDOMBreakpoint(node.id, type);
     234            DOMDebuggerAgent.setDOMBreakpoint(node.id, type);
    235235        else
    236             BrowserDebuggerAgent.removeDOMBreakpoint(node.id, type);
     236            DOMDebuggerAgent.removeDOMBreakpoint(node.id, type);
    237237        this._saveBreakpoints();
    238238    },
  • trunk/Source/WebCore/inspector/generate-inspector-idl

    r85319 r85597  
    8989    "ApplicationCache": "OFFLINE_WEB_APPLICATIONS",
    9090    "Debugger": "JAVASCRIPT_DEBUGGER",
    91     "BrowserDebugger": "JAVASCRIPT_DEBUGGER",
     91    "DOMDebugger": "JAVASCRIPT_DEBUGGER",
    9292    "Profiler": "JAVASCRIPT_DEBUGGER",
    9393    "Worker": "WORKERS"
Note: See TracChangeset for help on using the changeset viewer.