Changeset 85606 in webkit

Timestamp:

May 3, 2011 9:18:29 AM (13 years ago)

Author:

caseq@chromium.org

Message:

2011-05-03 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
​https://bugs.webkit.org/show_bug.cgi?id=60026

Return a wrapper for Node in toV8(Node*) when called with a node of type
SHADOW_ROOT_NODE instead of entering infinite recursion.

• bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8NodeCustom.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-05-03  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
+        https://bugs.webkit.org/show_bug.cgi?id=60026
+
+        Return a wrapper for Node in toV8(Node*) when called with a node of type
+        SHADOW_ROOT_NODE instead of entering infinite recursion.
+
+        * bindings/v8/custom/V8NodeCustom.cpp:
+        (WebCore::toV8Slow):
+
 2011-05-02  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp

@@ -165 +165 @@
     case Node::DOCUMENT_FRAGMENT_NODE:
         return toV8(static_cast<DocumentFragment*>(impl), forceNewObject);
-    case Node::SHADOW_ROOT_NODE:
-        return toV8(static_cast<ShadowRoot*>(impl), forceNewObject);
     case Node::NOTATION_NODE:
         return toV8(static_cast<Notation*>(impl), forceNewObject);
+    case Node::SHADOW_ROOT_NODE: // There's no IDL class for ShadowRoot, fall-through to default and use Node instead.
     default: break; // XPATH_NAMESPACE_NODE
     }