Changeset 85667 in webkit

Timestamp:

May 3, 2011 3:05:22 PM (13 years ago)

Author:

luiz@webkit.org

Message:

[Qt] Layout tests may timeout if loadFinished receives false
​https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

• DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/qt/LayoutTestControllerQt.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
+
+        Reviewed by NOBODY Kenneth Rohde Christiansen.
+
+        [Qt] Layout tests may timeout if loadFinished receives false
+        https://bugs.webkit.org/show_bug.cgi?id=60064
+
+        When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
+        then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
+        a response is ignored, like it should be for 204 responses. It is a problem for creating
+        tests for 204 responses for example.
+
+        This change has been tested and it causes no regressions in layout tests.
+
+        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
+        (LayoutTestController::maybeDump):
+
 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

@@ -106 +106 @@
 
 // Called on loadFinished on WebPage
-void LayoutTestController::maybeDump(bool success)
+void LayoutTestController::maybeDump(bool /*success*/)
 {
 
@@ -132 +132 @@
         QTimer::singleShot(0, this, SLOT(processWork()));
     else if (!shouldWaitUntilDone()) {
-        if (success)
-            emit done();
+        emit done();
         m_hasDumped = true;
     }