Changeset 85753 in webkit


Ignore:
Timestamp:
May 4, 2011 9:53:20 AM (13 years ago)
Author:
Adam Roben
Message:

Let transparent windowless plugins draw into a graphics context with an alpha channel

Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows

I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r85746 r85753  
     12011-05-04  Adam Roben  <aroben@apple.com>
     2
     3        Let transparent windowless plugins draw into a graphics context with an alpha channel
     4
     5        Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
     6        wmode=transparent have black (instead of transparent) background in WebKit2 on Windows
     7
     8        I had trouble writing a test case for this, so I split that task out into
     9        <http://webkit.org/b/60169>.
     10
     11        Reviewed by Sam Weinig.
     12
     13        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
     14        (WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
     15        is a transparent windowless plugin.
     16
    1172011-05-03  Adam Roben  <aroben@apple.com>
    218
  • trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp

    r85502 r85753  
    180180    m_pluginController->willSendEventToPlugin();
    181181   
    182     // FIXME: Support transparent plugins.
    183     LocalWindowsContext windowsContext(context, dirtyRect, false);
     182    LocalWindowsContext windowsContext(context, dirtyRect, m_isTransparent);
    184183
    185184    m_npWindow.type = NPWindowTypeDrawable;
Note: See TracChangeset for help on using the changeset viewer.